Unreviewed libgcc patches

Unreviewed libgcc patches

[Rainer Orth]

The following two libgcc patches have seen almost no comments, and
certainly neither testing or review in a week:

	CFT: [build] Move fp-bit support to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00927.html

	CFT: [build] Move soft-fp support to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00931.html

This patch will need to be updated for the recent addition of the c6x
port.

Both will probably need build and libgcc maintainers and either a bunch
of target maintainers or a global reviewer.  I wonder how to proceed
here: I've got a bunch of further libgcc patches in the works or
planned, but if I can't get them reviewed, there's no point in
continuing that work.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libgcc patches

[NightStrike]

On Mon, Jul 18, 2011 at 8:21 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> The following two libgcc patches have seen almost no comments, and
> certainly neither testing or review in a week:
>
>        CFT: [build] Move fp-bit support to toplevel libgcc
>        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00927.html
>
>        CFT: [build] Move soft-fp support to toplevel libgcc
>        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00931.html
>
> This patch will need to be updated for the recent addition of the c6x
> port.
>
> Both will probably need build and libgcc maintainers and either a bunch
> of target maintainers or a global reviewer.  I wonder how to proceed
> here: I've got a bunch of further libgcc patches in the works or
> planned, but if I can't get them reviewed, there's no point in
> continuing that work.

Do you still need support?

Re: Unreviewed libgcc patches

[Rainer Orth]

NightStrike <nightstrike@gmail.com> writes:

> On Mon, Jul 18, 2011 at 8:21 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
>> The following two libgcc patches have seen almost no comments, and
>> certainly neither testing or review in a week:
>>
>>        CFT: [build] Move fp-bit support to toplevel libgcc
>>        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00927.html
>>
>>        CFT: [build] Move soft-fp support to toplevel libgcc
>>        http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00931.html
>>
>> This patch will need to be updated for the recent addition of the c6x
>> port.
>>
>> Both will probably need build and libgcc maintainers and either a bunch
>> of target maintainers or a global reviewer.  I wonder how to proceed
>> here: I've got a bunch of further libgcc patches in the works or
>> planned, but if I can't get them reviewed, there's no point in
>> continuing that work.
>
> Do you still need support?

No: I've since received review comments for both and am working to
incorporate them and complete the remaining libgcc build-related
patches.

What would help is target maintainers actually reviewing or trying the
patches.  I'll probably wait until I've (re-)posted the full set and
start a new CFT then.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libgcc patches

[Paolo Bonzini]

On 10/06/2011 12:21 PM, Rainer Orth wrote:
>> >  Can you post an updated patch for this one?  I'll try to review the others
>> >  as soon as possible.
> Do you see a change to get the other patches reviewed before stage1
> closes?  I'd like to get them into 4.7 rather than carry them forward
> for several months.

Yes, I'm very sorry for the delay.

Paolo

Re: Unreviewed libgcc patches

[Rainer Orth]

Paolo Bonzini <bonzini@gnu.org> writes:

> On 09/22/2011 08:18 PM, Rainer Orth wrote:
>> 	[build] Move gthr to toplevel libgcc
>>          http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00762.html
>
> Can you post an updated patch for this one?  I'll try to review the others
> as soon as possible.

Do you see a change to get the other patches reviewed before stage1
closes?  I'd like to get them into 4.7 rather than carry them forward
for several months.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libgcc patches

[Paolo Bonzini]

On 09/22/2011 08:18 PM, Rainer Orth wrote:
> 	[build] Move gthr to toplevel libgcc
>          http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00762.html

Can you post an updated patch for this one?  I'll try to review the 
others as soon as possible.

Paolo

Unreviewed libgcc patches

[Rainer Orth]

The following libgcc patches haven't been reviewed for about a month:

	CFT: [build] Move crtstuff support to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01273.html

	CFT: [build] Move libgcc1 to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01274.html

	CFT: [build] Move libgcc2 to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01275.html

Two others in the series are also pending:

	CFT: [build] Move shlib support to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00915.html

has been approved modulo VMS/IA64 and Win32 testing.  Tristan has
indicated to go ahead for the VMS side, but I haven't received any Win32
feedback.

	[build] Move gthr to toplevel libgcc
        http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00762.html

I've received confirmation in private mail that dce thread support as
discussed in the thread works, but no final approval yet.

I'm currently working on moving the target headers to libgcc, but that's
quite involved and I don't have even a prototype ready yet.

I'd like those patches reviewed before Stage 1 closes by the end of next
month to avoid having to keep them up-to-date for 4.8.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University