Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Paolo Bonzini <bonzini@gnu.org> writes:

>> @@ -116,7 +79,6 @@
>>   	"PICFLAG_FOR_TARGET=$(PICFLAG_FOR_TARGET)" \
>>   	"SHELL=$(SHELL)" \
>>   	"EXPECT=$(EXPECT)" \
>> -	"RUNTEST=$(RUNTEST)" \
>
> Leave this line here, and replace the definitions of EXPECT and RUNTEST in
> boehm-gc/testsuite/Makefile.am with this:
>
> EXPECT = expect
>
> Automake will provide a definition of RUNTEST on its own.  I know this is
> likely cut-and-paste. :)  I'll reply that mine is cut-and-paste from
> libstdc++-v3/testsuite/Makefile.am.

... which is fine since it's shorter :-)

>> @@ -163,9 +164,9 @@
>>        *-*-hpux10*)
>>   	AC_MSG_WARN("Only HP-UX 11 POSIX threads are supported.")
>>   	;;
>> -      *-*-kfreebsd*-gnu)
>> +     *-*-kfreebsd*-gnu)
>>          AC_DEFINE(GC_FREEBSD_THREADS)
>> -       INCLUDES="$INCLUDES -pthread"
>> +       THREADCFLAGS=-pthread
>>          THREADDLLIBS=-pthread
>
> Please change this THREADLIBS since you're at it.

Done.

> Otherwise, build parts are okay.

Thanks.  I've retested the resulting patch with a java-only bootstrap on
i386-pc-solaris2.10 and installed on mainline.

I expect there will be problems on some targets, but we'll never know
until this is checked in for wider exposure.

Thanks to all of you who helped me on this journey with comments,
testing and advice.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University