From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8394 invoked by alias); 25 Mar 2011 17:07:07 -0000 Received: (qmail 8384 invoked by uid 22791); 25 Mar 2011 17:07:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 17:07:01 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id A3812F60; Fri, 25 Mar 2011 18:07:00 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NFhKRyPrI7YE; Fri, 25 Mar 2011 18:06:59 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id E1B87F5F; Fri, 25 Mar 2011 18:06:58 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p2PH6v7W019194; Fri, 25 Mar 2011 18:06:57 +0100 (MET) From: Rainer Orth To: Paolo Bonzini Cc: Mike Stump , IainS , Ralf Wildenhues , GCC Patches , Hans Boehm , Ben Elliston Subject: Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412) References: <20110106211734.GG17791@gmx.de> <4D8C70E7.4040409@gnu.org> Date: Fri, 25 Mar 2011 17:10:00 -0000 In-Reply-To: <4D8C70E7.4040409@gnu.org> (Paolo Bonzini's message of "Fri, 25 Mar 2011 11:39:35 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg01773.txt.bz2 Paolo Bonzini writes: >> @@ -116,7 +79,6 @@ >> "PICFLAG_FOR_TARGET=$(PICFLAG_FOR_TARGET)" \ >> "SHELL=$(SHELL)" \ >> "EXPECT=$(EXPECT)" \ >> - "RUNTEST=$(RUNTEST)" \ > > Leave this line here, and replace the definitions of EXPECT and RUNTEST in > boehm-gc/testsuite/Makefile.am with this: > > EXPECT = expect > > Automake will provide a definition of RUNTEST on its own. I know this is > likely cut-and-paste. :) I'll reply that mine is cut-and-paste from > libstdc++-v3/testsuite/Makefile.am. ... which is fine since it's shorter :-) >> @@ -163,9 +164,9 @@ >> *-*-hpux10*) >> AC_MSG_WARN("Only HP-UX 11 POSIX threads are supported.") >> ;; >> - *-*-kfreebsd*-gnu) >> + *-*-kfreebsd*-gnu) >> AC_DEFINE(GC_FREEBSD_THREADS) >> - INCLUDES="$INCLUDES -pthread" >> + THREADCFLAGS=-pthread >> THREADDLLIBS=-pthread > > Please change this THREADLIBS since you're at it. Done. > Otherwise, build parts are okay. Thanks. I've retested the resulting patch with a java-only bootstrap on i386-pc-solaris2.10 and installed on mainline. I expect there will be problems on some targets, but we'll never know until this is checked in for wider exposure. Thanks to all of you who helped me on this journey with comments, testing and advice. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University