From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Iain Buclaw via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libphobos: libdruntime doesn't support shadow stack (PR95680)
Date: Tue, 08 Sep 2020 23:34:17 +0200 [thread overview]
Message-ID: <yddk0x4dkbq.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <1599560137.uqp3ab0rt4.astroid@galago.none> (Iain Buclaw via Gcc-patches's message of "Tue, 08 Sep 2020 12:16:45 +0200")
Hi Iain,
>>> ---
>>> libphobos/ChangeLog:
>>>
>>> PR d/95680
>>> * Makefile.in: Regenerate.
>>> * configure: Regenerate.
>>> * configure.ac (DCFG_ENABLE_CET): Substitute.
>>> * libdruntime/Makefile.in: Regenerate.
>>> * libdruntime/config/x86/switchcontext.S: Remove CET support code.
>>> * libdruntime/core/thread.d: Import gcc.config. Don't set version
>>> AsmExternal when GNU_Enable_CET is true.
>>> * libdruntime/gcc/config.d.in (GNU_Enable_CET): Define.
>>> * src/Makefile.in: Regenerate.
>>> * testsuite/Makefile.in: Regenerate.
>>
>> Looks good. I can try it on Tiger Lake after it has been checked in.
>>
>
> OK, I have committed it as r11-3047.
this patch broke Solaris/x86 bootstrap:
/vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3595:23: error: version AsmExternal defined after use
3595 | version = AsmExternal;
| ^
/vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3603:27: error: version AsmX86_Posix defined after use
3603 | version = AsmX86_Posix;
| ^
and similarly for the 64-bit version. libdruntime/gcc/config.d has
// Whether libphobos been configured with --enable-cet.
enum GNU_Enable_CET = false;
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2020-09-08 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 21:35 Iain Buclaw
2020-09-08 2:09 ` H.J. Lu
2020-09-08 10:16 ` Iain Buclaw
2020-09-08 21:34 ` Rainer Orth [this message]
2020-09-09 22:57 ` Iain Buclaw
2020-09-10 10:41 ` Rainer Orth
2020-09-09 17:08 ` [PATCH] libphobos: Include <cet.h> to generate the CET marker for -fcf-protection H.J. Lu
2020-09-09 17:20 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddk0x4dkbq.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).