From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id DC086385702B for ; Tue, 8 Sep 2020 21:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC086385702B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 8BA256A68; Tue, 8 Sep 2020 23:34:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4YPU0szbFyLl; Tue, 8 Sep 2020 23:34:18 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddbb33.dip0.t-ipconnect.de [79.221.187.51]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 5E7964C41; Tue, 8 Sep 2020 23:34:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1599600858; bh=v8hRPmOwyL3ZSesfWXeSAUVdzHeTcuJKMcjq4HjXuIk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m4TGUk5zHqt+SlOoYHX08+EZEu2SSKRNa46Ai4Ow3IPu6syNks1yWJtWrV44Ls4SV K6gnajxISlZZdpVNtNbopzBeYQWi+FN2t15+2jwm0QojKJTNZ8DvhQfttwFplcwlJ/ ssUHVassimCQ+b84T4+l5czcDsYDpEg69HZNRtbSVQwugZEwXjCVCMoCz54W5n+y4b Gk1dNTE6W/vWziFF9skOjdzeCNZoyNxt7uHC5EsL46gu7E3PPR010bcrevDByPnpjE UUjsWjWceIqlv41IO9L+/lN7lSl/dbPuY7AnL1Iq5yAyNZvV8VUbv8ZOO2gulFCtvE a64WXTSc2dTiw== From: Rainer Orth To: Iain Buclaw via Gcc-patches Subject: Re: [PATCH] libphobos: libdruntime doesn't support shadow stack (PR95680) References: <20200907213540.1881766-1-ibuclaw@gdcproject.org> <1599560137.uqp3ab0rt4.astroid@galago.none> Date: Tue, 08 Sep 2020 23:34:17 +0200 In-Reply-To: <1599560137.uqp3ab0rt4.astroid@galago.none> (Iain Buclaw via Gcc-patches's message of "Tue, 08 Sep 2020 12:16:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 21:34:29 -0000 Hi Iain, >>> --- >>> libphobos/ChangeLog: >>> >>> PR d/95680 >>> * Makefile.in: Regenerate. >>> * configure: Regenerate. >>> * configure.ac (DCFG_ENABLE_CET): Substitute. >>> * libdruntime/Makefile.in: Regenerate. >>> * libdruntime/config/x86/switchcontext.S: Remove CET support code. >>> * libdruntime/core/thread.d: Import gcc.config. Don't set version >>> AsmExternal when GNU_Enable_CET is true. >>> * libdruntime/gcc/config.d.in (GNU_Enable_CET): Define. >>> * src/Makefile.in: Regenerate. >>> * testsuite/Makefile.in: Regenerate. >> >> Looks good. I can try it on Tiger Lake after it has been checked in. >> > > OK, I have committed it as r11-3047. this patch broke Solaris/x86 bootstrap: /vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3595:23: error: version AsmExternal defined after use 3595 | version = AsmExternal; | ^ /vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3603:27: error: version AsmX86_Posix defined after use 3603 | version = AsmX86_Posix; | ^ and similarly for the 64-bit version. libdruntime/gcc/config.d has // Whether libphobos been configured with --enable-cet. enum GNU_Enable_CET = false; Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University