From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120454 invoked by alias); 25 Apr 2019 11:09:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120441 invoked by uid 89); 25 Apr 2019 11:09:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=sk:convers, gcctestresults, HX-Languages-Length:1007, gcc-testresults X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 11:09:06 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CAFB3D5B; Thu, 25 Apr 2019 13:09:02 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 53FgR0+-VI60; Thu, 25 Apr 2019 13:09:01 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 66BC9D5A; Thu, 25 Apr 2019 13:09:01 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id x3PB90qh017967; Thu, 25 Apr 2019 13:09:00 +0200 (MEST) From: Rainer Orth To: Richard Biener Cc: gcc-patches@gcc.gnu.org, jason@redhat.com Subject: Re: [PATCH][C++] Improve compile-time by ordering expensive checks last References: Date: Thu, 25 Apr 2019 11:27:00 -0000 In-Reply-To: (Richard Biener's message of "Wed, 17 Apr 2019 15:44:49 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00976.txt.bz2 Hi Richard, > On Tue, 16 Apr 2019, Richard Biener wrote: > >> >> Two cases from a -fsynax-only tramp3d callgrind profile. > > Amended by two others. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > 2019-04-17 Richard Biener > > cp/ > * call.c (null_ptr_cst_p): Order checks according to expensiveness. > (conversion_null_warnings): Likewise. > * typeck.c (same_type_ignoring_top_level_qualifiers_p): Return > early if type1 == type2. this patch caused +XPASS: g++.dg/warn/Wunused-var-35.C -std=gnu++98 bug (test for warnings, line 14) First seen on i386-pc-solaris2.11 and sparc-sun-solaris2.11, according to gcc-testresults everywhere. Confirmed by reverting the patch locally and re-testing the affected testcase. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University