From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76402 invoked by alias); 12 Aug 2017 14:16:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66133 invoked by uid 89); 12 Aug 2017 14:16:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=stand X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Aug 2017 14:16:16 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CD9B7B0D; Sat, 12 Aug 2017 16:16:13 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id c8M-38MsmkLv; Sat, 12 Aug 2017 16:16:12 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5DCE27C7.dip0.t-ipconnect.de [93.206.39.199]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id D8E2AB0B; Sat, 12 Aug 2017 16:16:11 +0200 (CEST) From: Rainer Orth To: Daniel Santos Cc: gcc-patches , Uros Bizjak , "H . J . Lu" , Mike Stump Subject: Re: [PATCH] [i386,testsuite] [PR 71958] Error on -mx32 with -mabi=ms References: <20170811212744.30180-1-daniel.santos@pobox.com> Date: Sun, 13 Aug 2017 15:26:00 -0000 In-Reply-To: <20170811212744.30180-1-daniel.santos@pobox.com> (Daniel Santos's message of "Fri, 11 Aug 2017 16:27:44 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00836.txt.bz2 Hi Daniel, > We currently error when -mx32 -mabi=sysv and we encounter a function > with attribute ms_abi, but we are not erroring on -mx32 and -mabi=ms > (either explicitly or when it is the default on Windows). In fact, it > generates code that runs, but is of an undfined ABI. > > I'm running -m64 and -m32 tests now and will run x32 tests when those > are done. Presuming that I've corrected all existing tests that do not > filter out x32 target and there are no additional failures, is this OK > for head? > > Thanks, > Daniel > > gcc/ChangeLog: > 2017-08-11 Daniel Santos > > * config/i386/i386.c (ix86_option_override_internal): Modify. > (ix86_function_type_abi): Likewise. those entries are pretty useless as they stand: you should state *what* you changed. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University