public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jan Hubicka <jh@suse.cz>
Subject: Re: [PR 79108] Put ipa_node_params to GC memory
Date: Mon, 23 Jan 2017 22:10:00 -0000	[thread overview]
Message-ID: <yddk29lsa9c.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20170120215807.yh7acd36yq4qd4ur@virgil.suse.cz> (Martin Jambor's	message of "Fri, 20 Jan 2017 22:58:08 +0100")

Hi Martin,

> when I fixed PR 78365 by streaming types of parameters that might not
> have been anywhere else, I forgot that I was holding them in non-GC
> memory and so I caused PR 79108.  The following patch fixes it by
> putting ipa_param_descriptor and ipa_node_params structures into GC
> memory, together with summary holding class ipa_node_params_t which is
> now a GC root.  In the process, I have turned the destructor of the
> latter into a remove and insert hooks of the summary holder.
>
> Bootstrapped and tested on x86_64-linux, also LTO-bootstrapped and
> tested, although with only C,C++ and Fortran and with sanitizers and
> multilib disabled.  (It is now a part of an undergoing  LTO bootstrap
> with everything).  OK for trunk?

this broke bootstrap on i386-pc-solaris2.12, sparc-sun-solaris2.12, and
i686-pc-linux-gnu (probably every 32-bit host), as confirmed by an
i386-pc-solaris2.10 reghunt.

E.g. in the Linux/i686 bootstrap, compiling tree-ssa-math-opts.o fails
with

virtual memory exhausted: Cannot allocate memory

In the Solaris cases, various libstdc++ source files fail to compile in
the same way.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

  parent reply	other threads:[~2017-01-23 22:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 22:27 Martin Jambor
2017-01-21  7:25 ` Andrew Pinski
2017-01-23  9:58 ` Richard Biener
2017-01-23 22:10 ` Rainer Orth [this message]
2017-01-24 10:11   ` Martin Jambor
2017-01-24 14:29     ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yddk29lsa9c.fsf@CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jh@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).