From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2297 invoked by alias); 10 Feb 2015 23:11:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2261 invoked by uid 89); 10 Feb 2015 23:11:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Feb 2015 23:11:12 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C0120586; Wed, 11 Feb 2015 00:11:09 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Pq0HXVQxwj2a; Wed, 11 Feb 2015 00:11:08 +0100 (CET) Received: from fuego.CeBiTec.Uni-Bielefeld.DE (p54878AB4.dip0.t-ipconnect.de [84.135.138.180]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 033E6585; Wed, 11 Feb 2015 00:11:07 +0100 (CET) From: Rainer Orth To: Jeff Law Cc: "H.J. Lu" , Magnus Granberg , gcc-patches@gcc.gnu.org Subject: Re: [testsuite] PATCH: Add check_effective_target_pie References: <20150111235837.GA26961@gmail.com> <54B42880.2040800@redhat.com> <2219602.BYtQkL3Scp@laptop1.gw.ume.nu> <54B444E4.1080700@redhat.com> <20150113125201.GA18558@gmail.com> <54B570D5.4040008@redhat.com> Date: Tue, 10 Feb 2015 23:11:00 -0000 In-Reply-To: <54B570D5.4040008@redhat.com> (Jeff Law's message of "Tue, 13 Jan 2015 12:24:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00662.txt.bz2 Jeff Law writes: >> Subject: [PATCH 1/5] Add check_effective_target_pie >> >> Hi, >> >> This patch adds check_effective_target_pie to check if the current >> multilib generates PIE by default. >> >> Thanks. >> >> H.J. >> --- >> 2015-01-11 H.J. Lu >> >> * gcc.target/i386/pie.c: New test. >> >> * lib/target-supports.exp (check_effective_target_pie): New. > OK. The new proc is bogus, unfortunately: there's already an existing check_effective_target_pie that checks if a target can support PIE. The new one just overrides the previous one. On targets supporting PIE (like Darwin), but not defaulting to it, the PIE tests suddenly turn out UNSUPPORTED. You should rename the new one to e.g. check_effective_target_pie_default, update the single user, and document it in sourcebuild.texi. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University