From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13649 invoked by alias); 23 May 2011 12:06:12 -0000 Received: (qmail 13631 invoked by uid 22791); 23 May 2011 12:06:11 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 12:05:57 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 5509869B; Mon, 23 May 2011 14:05:56 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hif70RPdz+FQ; Mon, 23 May 2011 14:05:54 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6434D69A; Mon, 23 May 2011 14:05:54 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p4NC5r7L015542; Mon, 23 May 2011 14:05:53 +0200 (MEST) From: Rainer Orth To: DJ Delorie Cc: gcc-patches@gcc.gnu.org, bonzini@gnu.org, Ralf.Wildenhues@gmx.de Subject: Re: Unreviewed build patches References: <201105210301.p4L31WDU017982@greed.delorie.com> Date: Mon, 23 May 2011 14:30:00 -0000 In-Reply-To: <201105210301.p4L31WDU017982@greed.delorie.com> (DJ Delorie's message of "Fri, 20 May 2011 23:01:32 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01624.txt.bz2 DJ Delorie writes: >> [build] More --enable-threads cleanup >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html >> >> This might well be obvious. > > Also, we usually leave those up to the target maintainers, since > they're target specific. But if it's just a correlation between the True, but finding maintainers for obsolete/removed ports might be difficult :-) > script and a list of source file options, go for it. I did, thanks. >> Besides, it would be helpful if a build maintainer could have a look at >> >> [build] Move Solaris 2 startup files to toplevel libgcc >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00098.html >> >> either to state that I don't need approval or to make suggestings for >> improvements. This is not yet the final patch, but the remainder is >> tuning. > > We normally let target maintainers manage anything in the build that's > target-specific. However, you've mixed in target patches with I know and usually act on that rule. I wasn't asking so much for approval but rather for suggestions for the build side of things. > target-independent patches. I have no problem with you checking in > your own target changes, but if you could split out the rest for > review, it would make it easier on us. I can try if the build maintainers need that. So far, I can only see use of the new generic libgcc/config/t-crtfm on sparc targets other than Solaris, and $< instead of pathnames in libgcc/config/i386/t-crtfm, gld detection and substitution of cpu_type. > Also, mention if you tested it on any ix86 non-solaris platform > (linux, bsd, etc). I didn't since apart from the t-crtfm stuff (which has been tested on Solaris already), there's nothing that could affect them. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University