From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 87405385608D for ; Thu, 7 Jul 2022 11:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87405385608D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 556A4B824D; Thu, 7 Jul 2022 13:52:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WfvG1f0tX3Fh; Thu, 7 Jul 2022 13:52:16 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508547b6.dip0.t-ipconnect.de [80.133.71.182]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id B66A1B83BD; Thu, 7 Jul 2022 13:52:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1657194736; bh=wp/13ZE6PkAychUcCi8Mv/j7pFUfiHe2oaoRWS8Ms2w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CZiP8kQX1aDUub12s3sFRAQrSLMHveiLM+qkTt/CJ80ouo+NOrfE2NjUzXDMXB5RJ aASPVgPgEOC9KxD0954eAmOVnTj3wu/4cL9NSznxvf1AcJKN6nvUe0FWdfm0uiq8uQ iguq0ktOzI4CVeY2QhLm7/bJCfV6YqH08yV2+DVeEkvlhGWineBUJZw6t1NtFHTr1M HGHsZxPhrkQs2fT1D52CTFfORgdY7radHLo1qTCxzFEog5u2ZN/PxNodhOFj2oTYb7 jr3ysjnVukSD4JqpTsbQ6/W1OudO+UAHziabCQLthjuVZh9nr+4H9Y/yQHRYQtkJg6 6ilrYp0xv3Fhg== From: Rainer Orth To: Richard Biener via Gcc-patches Subject: Re: [PATCH] lto-plugin: use locking only for selected targets References: <31546a0d-9103-dba2-cca7-261905441aa5@suse.cz> Date: Thu, 07 Jul 2022 13:52:16 +0200 In-Reply-To: (Richard Biener via Gcc-patches's message of "Thu, 7 Jul 2022 13:46:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3788.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 11:52:21 -0000 Richard Biener via Gcc-patches writes: >> +if test x$use_locking = xyes; then >> + AC_DEFINE(HAVE_PTHREAD_LOCKING, 1, >> + [Define if the system-provided pthread locking mechanism.]) This isn't even a sentence. At least I cannot parse it. Besides, it seems to be misnamed since the test doesn't check if pthread_mutex_lock and friends are present on the target, but if they should be used. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University