From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org
Subject: [v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86
Date: Mon, 10 Feb 2014 16:00:00 -0000 [thread overview]
Message-ID: <yddlhxjc60w.fsf@lokon.CeBiTec.Uni-Bielefeld.DE> (raw)
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Two libstdc++ testcases have been XPASSing on Solaris 9/x86 since
ca. 20130522:
XPASS: 22_locale/num_put/put/char/14220.cc execution test
XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test
Therefore I'd like to remove the xfails since the issue documented there
doesn't seem to trigger anymore.
Bootstrapped without regressions on i386-pc-solaris2.{9, 10, 11}. Ok
for mainline?
Rainer
2014-02-05 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* testsuite/22_locale/num_put/put/char/14220.cc: Don't xfail
execution on i?86-*-solaris2.9, remove comment.
* testsuite/22_locale/num_put/put/wchar_t/14220.cc: Likewise.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: solx86-v3-14220.patch --]
[-- Type: text/x-patch, Size: 1411 bytes --]
# HG changeset patch
# Parent 0f6d9b9bde5e7eee20486c180ceec28d5043bec7
Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86
diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
@@ -19,12 +19,6 @@
// 22.2.2.2.1 num_put members
-// On Solaris 9/x86 and 32-bit Solaris 10/x86 before update 10, this test
-// crashes in libc. Inside libstdc++, we call sprintf like so:
-// sprintf (buffer, "%.*f", 1000, 1.0)
-// which crashes.
-// { dg-xfail-run-if "" i?86-*-solaris2.9 }
-
#include <locale>
#include <sstream>
#include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
@@ -23,12 +23,6 @@
#include <sstream>
#include <testsuite_hooks.h>
-// On Solaris 9 and 32-bit Solaris 10/x86 before update 10, this test crashes
-// in libc. Inside libstdc++, we call sprintf like so:
-// sprintf (buffer, "%.*f", 1000, 1.0)
-// which crashes.
-// { dg-do run { xfail { i?86-*-solaris2.9 } } }
-
// libstdc++/14220
void test01()
{
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next reply other threads:[~2014-02-10 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 16:00 Rainer Orth [this message]
2014-02-10 16:05 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddlhxjc60w.fsf@lokon.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).