From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34201 invoked by alias); 10 Jan 2020 13:40:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34190 invoked by uid 89); 10 Jan 2020 13:40:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=H*i:sk:CAOyqgc, H*f:sk:CAOyqgc, vol, bufio X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 13:40:24 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C5741220; Fri, 10 Jan 2020 14:40:22 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Y05023AzNIuK; Fri, 10 Jan 2020 14:40:21 +0100 (CET) Received: from itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (itzacchiuatl.CeBiTec.Uni-Bielefeld.DE [129.70.161.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 71F4221F; Fri, 10 Jan 2020 14:40:21 +0100 (CET) Received: (from ro@localhost) by itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id 00ADeKiU026911; Fri, 10 Jan 2020 14:40:20 +0100 (CET) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches , gofrontend-dev Subject: Re: libgo patch committed: Compile examples in _test packages References: Date: Fri, 10 Jan 2020 13:51:00 -0000 In-Reply-To: (Ian Lance Taylor's message of "Thu, 9 Jan 2020 15:15:10 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00546.txt.bz2 Hi Ian, > This libgo patch compiles examples in _test packages. Previously if > the only names defined by _test packages were examples, the gotest > script would emit an incorrect _testmain.go file. I worked around > that by marking the example_test.go files +build ignored. This CL > changes the gotest script to handle this case correctly, and removes > the now-unnecessary build tags. Bootstrapped and ran Go testsuite on > x86_64-pc-linux-gnu. Committed to mainline. this patch breaks quite a number of libgo tests on Solaris: FAIL: bufio /vol/gcc/src/hg/trunk/local/libgo/testsuite/gotest[541]: local: not found [No such file or directory] Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University