From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jason Merrill <jason@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Tom Honermann <tom@honermann.net>,
Martin Sebor <msebor@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Marek Polacek <polacek@redhat.com>
Subject: Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal
Date: Fri, 18 Jan 2019 12:52:00 -0000 [thread overview]
Message-ID: <yddmuny86xe.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <5d6f1d8d-0e71-5d8e-d269-ee2aa50ab0b9@redhat.com> (Jason Merrill's message of "Thu, 17 Jan 2019 12:41:06 -0500")
Hi Jason,
> On 1/15/19 12:59 PM, Joseph Myers wrote:
>> On Tue, 15 Jan 2019, Jason Merrill wrote:
>>
>>> I actually incorporated the C++ part of these changes into yesterday's
>>> commit,
>>> using Martin's first suggestion. Here's the adjusted C patch, which I'd like
>>> a C maintainer to approve.
>>
>> The front-end changes are OK. However, in the testcase changes, some of
>> the new expected diagnostics are hardcoding that "unsigned int" is th
>> type of char32_t, which isn't correct for all platforms (for example, it's
>> definitely not the type when int is 16-bit). In principle the same
>> applies to diagnostics hardcoding the choice of char16_t, although
>> variations are at least less likely there.
>
> This updated patch removes {short ,}unsigned int from the expected
> diagnostics. And also improves error_init to accept additional arguments,
> like pedwarn_init already does.
>
> Tested x86_64-pc-linux-gnu.
there are now a couple of failures on several (32-bit?) targets:
+FAIL: gcc.dg/utf-array.c (test for errors, line 15)
+FAIL: gcc.dg/utf-array.c (test for errors, line 21)
+FAIL: gcc.dg/utf-array.c (test for errors, line 33)
I'm seeing it on i386-pc-solaris2.11 (32-bit only), and there are also
gcc-testresults reports on i686-pc-linux-gnu, m68k-unknown-linux-gnu,
and x86_64-pc-linux-gnu.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2019-01-18 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 21:29 Tom Honermann
2019-01-05 0:26 ` Martin Sebor
2019-01-15 4:10 ` Tom Honermann
2019-01-15 15:15 ` Jason Merrill
2019-01-15 16:00 ` Marek Polacek
2019-01-15 17:59 ` Joseph Myers
2019-01-17 17:41 ` Jason Merrill
2019-01-17 20:24 ` Joseph Myers
2019-01-18 12:52 ` Rainer Orth [this message]
2019-01-18 14:46 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddmuny86xe.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=msebor@gmail.com \
--cc=polacek@redhat.com \
--cc=tom@honermann.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).