From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49257 invoked by alias); 18 Jan 2019 12:52:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49238 invoked by uid 89); 18 Jan 2019 12:52:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Jan 2019 12:52:02 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 79CA62D1; Fri, 18 Jan 2019 13:52:00 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aXXmllP2S3X5; Fri, 18 Jan 2019 13:51:58 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 9AD9F2D0; Fri, 18 Jan 2019 13:51:58 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id x0ICpvgp024449; Fri, 18 Jan 2019 13:51:57 +0100 (MET) From: Rainer Orth To: Jason Merrill Cc: Joseph Myers , Tom Honermann , Martin Sebor , gcc-patches , Marek Polacek Subject: Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal References: <50dbd993-f778-a2a4-e63c-1c2b3b85de41@gmail.com> <21994e14-d1b8-e893-72d2-86b9674e0fab@honermann.net> <99ca7332-f658-d5fe-fc42-b4199111ad3d@redhat.com> <5d6f1d8d-0e71-5d8e-d269-ee2aa50ab0b9@redhat.com> Date: Fri, 18 Jan 2019 12:52:00 -0000 In-Reply-To: <5d6f1d8d-0e71-5d8e-d269-ee2aa50ab0b9@redhat.com> (Jason Merrill's message of "Thu, 17 Jan 2019 12:41:06 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01069.txt.bz2 Hi Jason, > On 1/15/19 12:59 PM, Joseph Myers wrote: >> On Tue, 15 Jan 2019, Jason Merrill wrote: >> >>> I actually incorporated the C++ part of these changes into yesterday's >>> commit, >>> using Martin's first suggestion. Here's the adjusted C patch, which I'd like >>> a C maintainer to approve. >> >> The front-end changes are OK. However, in the testcase changes, some of >> the new expected diagnostics are hardcoding that "unsigned int" is th >> type of char32_t, which isn't correct for all platforms (for example, it's >> definitely not the type when int is 16-bit). In principle the same >> applies to diagnostics hardcoding the choice of char16_t, although >> variations are at least less likely there. > > This updated patch removes {short ,}unsigned int from the expected > diagnostics. And also improves error_init to accept additional arguments, > like pedwarn_init already does. > > Tested x86_64-pc-linux-gnu. there are now a couple of failures on several (32-bit?) targets: +FAIL: gcc.dg/utf-array.c (test for errors, line 15) +FAIL: gcc.dg/utf-array.c (test for errors, line 21) +FAIL: gcc.dg/utf-array.c (test for errors, line 33) I'm seeing it on i386-pc-solaris2.11 (32-bit only), and there are also gcc-testresults reports on i686-pc-linux-gnu, m68k-unknown-linux-gnu, and x86_64-pc-linux-gnu. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University