From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45543 invoked by alias); 20 Aug 2018 08:57:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45525 invoked by uid 89); 20 Aug 2018 08:57:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_20,GIT_PATCH_2,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KAM_SHORT autolearn=ham version=3.3.2 spammy=H*Ad:D*oracle.com, equally, sp, $31,8 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Aug 2018 08:57:18 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0BC8B103C; Mon, 20 Aug 2018 10:57:16 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aKbcpa8+3iyM; Mon, 20 Aug 2018 10:57:14 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 40E16103B; Mon, 20 Aug 2018 10:57:14 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w7K8vB9b019375; Mon, 20 Aug 2018 10:57:11 +0200 (MEST) From: Rainer Orth To: Jeff Law Cc: Paul Hua , qing.zhao@oracle.com, gcc-patches , Jakub Jelinek , Richard Biener Subject: Re: [PATCH][Middle-end]patch for fixing PR 86519 References: <885E5FDA-DB64-4BEF-A476-16F2CF879E04@oracle.com> <08e76de9-c88f-4404-d5ae-21a8835190a9@redhat.com> Date: Mon, 20 Aug 2018 08:57:00 -0000 In-Reply-To: <08e76de9-c88f-4404-d5ae-21a8835190a9@redhat.com> (Jeff Law's message of "Fri, 17 Aug 2018 21:49:58 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01115.txt.bz2 Hi Jeff, > On 08/17/2018 09:43 PM, Paul Hua wrote: >> Hi Qing: >> >>> >>> the change has been committed as: >>> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=263563 >>> >>> >>> Qing >>> >> >> The strcmpopt_6.c test still fails on mips64el target. >> >> gcc.dg/strcmpopt_6.c: memcmp found 4 times >> FAIL: gcc.dg/strcmpopt_6.c scan-assembler-times memcmp 2 >> >> >> The mips asm output have ".reloc" info. >> >> ------------------------------------------------------------------------- >> ld $5,%got_page(.LC0)($28) >> ld $25,%call16(memcmp)($28) >> li $6,3 # 0x3 >> sd $31,8($sp) >> .reloc 1f,R_MIPS_JALR,memcmp >> 1: jalr $25 >> daddiu $5,$5,%got_ofst(.LC0) >> ---------------------------------------------------------------------------- >> >> scan-assembler find "4" times. > Ugh. :( There's probably other targets that are going to have similar > properties. I'm not really sure how to write a suitable assembler test > for this. > > Maybe we just need a different search result for MIPS (and potentially > other targets). we certainly do: I've reported a similar issue on sparc in PR testsuite/86519, but powerpc and s390x are equally affected. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University