From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Richard Henderson <rth@redhat.com>,
Anatoly Sokolov <aesok@post.ru>,
gcc-patches@gcc.gnu.org, ebotcazou@libertysurf.fr
Subject: Re: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P
Date: Wed, 04 May 2011 11:54:00 -0000 [thread overview]
Message-ID: <yddmxj2bs80.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <Pine.LNX.4.64.1105031907030.11522@digraph.polyomino.org.uk> (Joseph S. Myers's message of "Tue, 3 May 2011 19:15:56 +0000 (UTC)")
"Joseph S. Myers" <joseph@codesourcery.com> writes:
>> What is so hard about running grep when removing/renaming symbols???
>
> Generically, the presence of lots of nonobvious places that may turn out
> to use a symbol - ada/gcc-interface/, go/gofrontend, config/ for what one
> thinks of as front-end symbols, libgcc/ and other places outside of gcc/
> (being outside gcc/ is probably how the remaining use of ROUND_TYPE_SIZE
> in libobjc was missed when that macro was removed from GCC in 2003), C
> symbols used directly in Ada source code, .... The ongoing work on
> narrowing interfaces (so that it's well-defined whether particular headers
> are used for the host or the target, tm.h isn't included in so many
> places, etc.) may help - though another thing to watch out for there is
> random declarations in .c files or inappropriate headers that mean that
> something uses a symbol from some part of the compiler despite not
> including the normal header that declares it (I found plenty of such cases
> when making options variables into macros). Help in cleaning up
> interfaces is always welcome - there's a lot to do
> (<http://gcc.gnu.org/wiki/Top-Level_Libgcc_Migration> has notes dealing
> with the very narrow area of target macros in code built for the target).
certainly true in general, although grep -r over the whole tree isn't
too hard to use either ;-) But in the case at hand,
$ grep print_operand *
in gcc/config/sparc would have turned up the problem at once, that's why
I'm complaining.
Your expansion of the wiki page on toplevel libgcc migration is
certainly welcome: I hadn't seen before that *-unwind.h files and
related macros can be moved over as well.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2011-05-04 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 18:43 Anatoly Sokolov
2011-04-28 16:18 ` Richard Henderson
2011-05-03 19:07 ` Rainer Orth
2011-05-03 19:18 ` Joseph S. Myers
2011-05-04 11:54 ` Rainer Orth [this message]
2011-05-04 12:02 ` Joseph S. Myers
2011-05-26 11:49 ` Completing toplevel libgcc move (Was: Re: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P) Rainer Orth
2011-05-26 13:24 ` Joseph S. Myers
2011-05-26 13:31 ` Completing toplevel libgcc move Rainer Orth
2011-05-04 17:44 ` Re[2]: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P Anatoly Sokolov
2011-05-04 17:44 ` Rainer Orth
2011-05-05 9:15 ` Rainer Orth
2011-05-13 7:02 ` Re[2]: " Anatoly Sokolov
2011-05-19 13:00 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddmxj2bs80.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=aesok@post.ru \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).