From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini <bonzini@gnu.org>
Subject: Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)
Date: Fri, 11 Mar 2011 15:18:00 -0000 [thread overview]
Message-ID: <yddmxl1vg7d.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <alpine.LNX.2.00.1103111608390.25982@zhemvz.fhfr.qr> (Richard Guenther's message of "Fri, 11 Mar 2011 16:10:13 +0100 (CET)")
Richard Guenther <rguenther@suse.de> writes:
>> Still doesn't work for me if compiling and linking manually with GNU ld
>> 2.21 on Solaris 11/x86: no .res file is being created, although
>> liblto_plugin.so is used.
>
> "Work" as in, it detects if -fuse-linker-plugin is enabled by default.
> Which it isn't for you?
I'm using gld 2.21, and -flto automatically uses the linker plugin, as
seen with -v. Despite that, -plugin-opt=-fresolution=ldl.res is passed
to collect2/ld, but no ldl.res file is created. In truss, I see a stat
of that file, but nothing more.
>> > Eventually scanning -v output for '-plugin' is better.
>>
>> This can only work if we make sure that -plugin is only passed to
>> linkers that properly handle it.
>
> Sure, but your version check patch part would ensure that, if not
> overridden by -fuse-linker-plugin.
No, -fuse-linker-plugin wouldn't override here: that option is only
accepted if we know that the linker has *some* -plugin support.
>> Why do you say so? The tri-state solution I've outlined only disables it
>> completely for non-GNU linkers. The plugin is used automatically for
>> gld/gold 2.21+ and for gold 2.20* if -fuse-linker-plugin is given.
>>
>> I don't see the `almost everyone' here, on the contrary: the situation
>> is identical to what we have now, with the exception that we don't try
>> to pass -plugin to linkers we don't know they can somehow (even with
>> restrictions) handle it. That's what PR lto/46944 is primarily about.
>
> Can you update your patch with the tri-state solution?
Sure if the solution is deemed acceptable. There isn't much point in
following that route if you see problems up front.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2011-03-11 15:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 12:11 Rainer Orth
2011-02-14 19:44 ` Ralf Wildenhues
2011-03-10 11:26 ` Rainer Orth
2011-03-10 11:51 ` Paolo Bonzini
2011-03-10 12:26 ` Richard Guenther
2011-03-10 16:51 ` Rainer Orth
2011-03-10 17:06 ` Richard Guenther
2011-03-10 18:28 ` Rainer Orth
2011-03-11 12:30 ` Richard Guenther
2011-03-11 14:37 ` Rainer Orth
2011-03-11 15:10 ` Richard Guenther
2011-03-11 15:18 ` Rainer Orth [this message]
2011-03-11 15:32 ` Richard Guenther
2011-03-11 15:35 ` Rainer Orth
2011-03-14 19:07 ` Rainer Orth
2011-03-15 9:42 ` Richard Guenther
2011-03-16 9:23 ` Rainer Orth
2011-03-16 9:27 ` Paolo Bonzini
2011-03-16 9:43 ` Rainer Orth
2011-03-18 9:27 ` Rainer Orth
2011-03-18 10:09 ` Richard Guenther
2011-03-18 10:16 ` Rainer Orth
2011-03-18 10:19 ` Richard Guenther
2011-03-18 10:23 ` Rainer Orth
2011-03-18 10:34 ` Richard Guenther
2011-03-21 10:18 ` Rainer Orth
2011-03-21 10:27 ` Paolo Bonzini
2011-03-21 10:27 ` Richard Guenther
2011-03-26 3:26 Michael Matz
2011-03-26 11:15 ` Richard Guenther
2011-03-28 10:20 ` Rainer Orth
2011-03-28 10:50 ` Richard Guenther
2011-04-04 16:16 ` Rainer Orth
2011-04-11 13:26 ` Rainer Orth
2011-04-18 18:34 ` Ralf Wildenhues
2011-04-19 17:53 ` Rainer Orth
2011-04-26 16:01 ` Rainer Orth
2011-04-26 22:27 ` Ralf Wildenhues
2011-04-27 14:36 ` Rainer Orth
2011-04-19 12:28 ` Paolo Bonzini
2011-04-19 17:57 ` Rainer Orth
2011-05-30 10:27 ` Rainer Orth
2011-05-30 10:45 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddmxl1vg7d.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).