From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: Jeff Law <law@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [patch] canonicalize unsigned [1,MAX] ranges into ~[0,0]
Date: Tue, 15 Oct 2019 11:59:00 -0000 [thread overview]
Message-ID: <yddo8yigqzg.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <4a1ab265-cd1d-71b3-c2c7-31cd3667fa54@redhat.com> (Aldy Hernandez's message of "Mon, 7 Oct 2019 08:28:04 -0400")
Hi Aldy,
>>> ~[0,0] has been the accepted way for a long time, I'd really prefer to
>>> keep that (for now).
>> It has. Very true. But I don't necessarily think that means we should
>> be introducing even more of 'em.
[...]
> Happily, normalizing into ~0 for signed and [1,MAX] for unsigned,
> simplified the patch because it on longer needs tweaks to
> ranges_from_anti_range.
>
> OK for trunk?
the new testcase FAILs on several (all?) 32-bit targets:
+FAIL: gcc.dg/tree-ssa/evrp4.c scan-tree-dump evrp "\\\\[1B, -1B\\\\]"
I'm seeing this on 32-bit i386-pc-solaris2.11 and sparc-sun-solaris2.11,
with more reports for armv8l, pru, and s390x.
Comparing the dumps between 64 and 32-bit, I see
-_1: int * [1B, -1B]
+_1: int * [1B, 4294967295B]
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2019-10-15 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 12:59 Aldy Hernandez
2019-10-04 15:38 ` Jeff Law
2019-10-04 15:49 ` Aldy Hernandez
2019-10-04 16:02 ` Jeff Law
2019-10-04 16:14 ` Aldy Hernandez
2019-10-04 17:17 ` Jeff Law
2019-10-07 12:28 ` Aldy Hernandez
2019-10-13 16:32 ` Jeff Law
2019-10-15 11:59 ` Rainer Orth [this message]
2019-10-15 12:37 ` Aldy Hernandez
2019-10-15 12:45 ` Rainer Orth
2019-10-15 13:07 ` Iain Sandoe
2019-10-15 18:21 ` Jakub Jelinek
2019-10-16 7:46 ` Aldy Hernandez
2019-10-16 8:14 ` Jakub Jelinek
2019-10-17 7:17 ` Aldy Hernandez
2019-10-17 7:38 ` Jakub Jelinek
2019-10-04 16:29 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddo8yigqzg.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).