From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Mike Stump <mikestump@comcast.net>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix *ivdep* tests on SPARC etc. (PR testsuite/88369, take 2)
Date: Mon, 10 Dec 2018 12:15:00 -0000 [thread overview]
Message-ID: <yddo99t60jf.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20181210120019.GY12380@tucnak> (Jakub Jelinek's message of "Mon, 10 Dec 2018 13:00:19 +0100")
Hi Jakub,
> As mentioned in the PR, another testcase was missed, this patch modifies
> that one too. Ok for trunk?
>
> 2018-12-10 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/88369
> * gcc.dg/vect/vect-ivdep-1.c: Prune versioning for alignment messages.
> * gcc.dg/vect/vect-ivdep-2.c: Likewise.
> * gcc.dg/vect/nodump-vect-opt-info-1.c: Likewise.
> * g++.dg/vect/pr33426-ivdep.cc: Likewise.
> * g++.dg/vect/pr33426-ivdep-2.cc: Likewise.
> * g++.dg/vect/pr33426-ivdep-3.cc: Likewise.
> * g++.dg/vect/pr33426-ivdep-4.cc: Likewise.
> --- gcc/testsuite/gcc.dg/vect/nodump-vect-opt-info-1.c.jj 2018-09-29 18:03:11.562727541 +0200
> +++ gcc/testsuite/gcc.dg/vect/nodump-vect-opt-info-1.c 2018-12-10 12:57:56.714484728 +0100
> @@ -6,6 +6,7 @@ vadd (int *dst, int *op1, int *op2, int
> {
> /* { dg-optimized "loop vectorized" "" { target *-*-* } .+2 } */
> /* { dg-optimized "loop versioned for vectorization because of possible aliasing" "" { target *-*-* } .+1 } */
> +/* { dg-prune-output " version\[^\n\r]* alignment" } */
> for (int i = 0; i < count; ++i)
> dst[i] = op1[i] + op2[i];
> }
this is wrong: either move the dg-prune-output before the first
dg-optimized (preferably) or adjust the line number distances to account
for the additional line.
Ok with that fixed.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
prev parent reply other threads:[~2018-12-10 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 7:07 [PATCH] Fix *ivdep* tests on SPARC etc. (PR testsuite/88369) Jakub Jelinek
2018-12-10 12:00 ` [PATCH] Fix *ivdep* tests on SPARC etc. (PR testsuite/88369, take 2) Jakub Jelinek
2018-12-10 12:15 ` Rainer Orth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddo99t60jf.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).