From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25227 invoked by alias); 30 Sep 2016 22:16:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25136 invoked by uid 89); 30 Sep 2016 22:16:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=20161001, 2016-10-01, H*Ad:U*ian, garbage X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Sep 2016 22:16:27 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id E262C844; Sat, 1 Oct 2016 00:16:24 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id o0U5wt86roWW; Sat, 1 Oct 2016 00:16:22 +0200 (CEST) Received: from fuego.CeBiTec.Uni-Bielefeld.DE (p5DCE3C16.dip0.t-ipconnect.de [93.206.60.22]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 05EC2843; Sat, 1 Oct 2016 00:16:21 +0200 (CEST) From: Rainer Orth To: Eric Gallager Cc: Jakub Jelinek , Andrew Haley , Ian Lance Taylor , Marek Polacek , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix bootstrap with --enable-languages=all,go References: <78f841e7-808b-58d0-7913-3ec0d19630a0@redhat.com> <84c4f4e2-3048-f5f8-de72-b2f704aa1389@redhat.com> <20160930102746.GB3223@redhat.com> <20160930185531.GE7282@tucnak.redhat.com> Date: Fri, 30 Sep 2016 23:52:00 -0000 In-Reply-To: (Eric Gallager's message of "Fri, 30 Sep 2016 15:52:12 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg02439.txt.bz2 --=-=-= Content-Type: text/plain Content-length: 860 Hi Eric, >> I haven't tried to readd the boehm-gc objc support that has also been >> disabled, don't know about anybody using that. > > I always configure with --enable-objc-gc. The only reason Apple > deprecated garbage collection for Objective C is because they replaced > it with Automated Reference Counting in clang, which GCC doesn't > support yet. So, until GCC supports Automated Reference Counting, > please keep boehm-gc support for objc. me too, though mostly to have maximum test coverage (primarily on Solaris). As expected, a x86_64-apple-darwin16 bootstrap with --enable-objc-gc just failed for me. I'm testing the following patch (on top of Jakub's). Rainer 2016-10-01 Rainer Orth * configure.ac (target_libraries): Readd target-boehm-gc. Restore --enable-objc-gc handling. * configure: Regenerate. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=eog.patch Content-length: 1246 --- configure.ac.pre-bgc 2016-09-30 23:20:44.000000000 +0200 +++ configure.ac 2016-09-30 23:28:35.952184178 +0200 @@ -161,6 +161,7 @@ target_libraries="target-libgcc \ target-libssp \ target-libquadmath \ target-libgfortran \ + target-boehm-gc \ target-libffi \ target-libobjc \ target-libada \ @@ -2054,6 +2055,28 @@ for dir in $configdirs $build_configdirs fi done +# Check for Boehm's garbage collector +AC_ARG_ENABLE(objc-gc, +[AS_HELP_STRING([--enable-objc-gc], + [enable use of Boehm's garbage collector with the + GNU Objective-C runtime])], +[case ,${enable_languages},:${enable_objc_gc}:${noconfigdirs} in + *,objc,*:*:yes:*target-boehm-gc*) + AC_MSG_ERROR([Boehm's garbage collector was requested yet not supported in this configuration]) + ;; +esac]) + +# Make sure we only build Boehm's garbage collector if required. +case ,${enable_languages},:${enable_objc_gc} in + *,objc,*:yes) + # Keep target-boehm-gc if requested for Objective-C. + ;; + *) + # Otherwise remove target-boehm-gc. + noconfigdirs="$noconfigdirs target-boehm-gc" + ;; +esac + # Disable libcilkrts, libitm, libsanitizer, libvtv, liboffloadmic if we're not building C++ case ,${enable_languages}, in *,c++,*) --=-=-= Content-Type: text/plain Content-length: 143 -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-=--