public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Unreviewed build/libgcc, mudflap patches
Date: Mon, 27 Jun 2011 18:03:00 -0000	[thread overview]
Message-ID: <yddoc1j88hi.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20110627144616.GH18441@redhat.com> (Frank Ch. Eigler's message	of "Mon, 27 Jun 2011 10:46:16 -0400")

Hi Frank,

> Sure.  Transcribing:
>
>> One generic issue came up with the port: enabling or disabling
>> libmudflap depends on a factor (linker support for --wrap/-z wrap)
>> that is best checked dynamically, thus doesn't really seem to belong
>> at the toplevel.  Is there any precedent for performing such a test
>> in the target library and enabling or disabling depending on the
>> outcome?  [...]
>
> I don't know.

perhaps one of the build maintainers has a suggestion.  For the time
being, I'll juts continue with --enable-libmudflap.

>> It seems the failures fall into only a few categories.  It's
>> probably best to analyse and fix those before checking in the patch.
>> Where should we continue discussing the failures?  Here or rather in
>> the PR?
>
> Separate PRs would be best.

I've now filed

libmudflap/49549	Use of --noinhibit-exec is unportable
libmudflap/49550	Many libmudflap tests fail on Solaris 11/x86

The second one almost certainly covers a couple of different issues, but
I cannot identify them yet, so any help is appreciated.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

  reply	other threads:[~2011-06-27 17:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 12:03 Rainer Orth
2011-06-27 12:29 ` Frank Ch. Eigler
2011-06-27 12:39   ` Rainer Orth
2011-06-27 14:58     ` Frank Ch. Eigler
2011-06-27 18:03       ` Rainer Orth [this message]
2011-06-27 18:00   ` Rainer Orth
2011-06-27 17:03 ` Iain Sandoe
2011-06-27 18:25   ` Rainer Orth
2011-06-27 20:07   ` Mike Stump
2011-06-29  8:27 ` Arnaud Charlet
2011-06-29  8:29   ` Rainer Orth
2011-06-29  8:38     ` Arnaud Charlet
2011-06-29  8:52 ` Paolo Bonzini
2011-06-29  9:09   ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yddoc1j88hi.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=fche@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).