From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11765 invoked by alias); 19 May 2011 13:40:24 -0000 Received: (qmail 11681 invoked by uid 22791); 19 May 2011 13:40:22 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 13:40:04 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CC0922E9; Thu, 19 May 2011 15:40:02 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qMK76nDZ58gv; Thu, 19 May 2011 15:40:00 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id C72B02E8; Thu, 19 May 2011 15:40:00 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p4JDdxiX013330; Thu, 19 May 2011 15:39:59 +0200 (MEST) From: Rainer Orth To: Revital Eres Cc: gcc-patches@gcc.gnu.org, Ayal Zaks Subject: Re: [PR testsuite/47013] Fix SMS testsuite faliures (re-submission) References: Date: Thu, 19 May 2011 16:52:00 -0000 In-Reply-To: (Revital Eres's message of "Tue, 17 May 2011 08:30:17 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01391.txt.bz2 Revital, you should seek review from a subject matter expert (Ayal, I suppose). Just a few nits on the testsuite side: > testsuite/Changelog > > PR rtl-optimization/47013 > * gcc.dg/sms-2.c: Change scan-tree-dump-times and the code itself > to preserve the function. > * gcc.dg/sms-6.c: Add --param sms-min-sc=1 > -fmodulo-sched-allow-regmoves, > and -mno-update for PowerPC. ^ superfluous whitespace I usually list the exact target triplets instead of PowerPC, SPU, but that may be a matter of taste. > Index: testsuite/gcc.dg/sms-6.c > =================================================================== > --- testsuite/gcc.dg/sms-6.c (revision 173659) > +++ testsuite/gcc.dg/sms-6.c (working copy) > @@ -1,5 +1,7 @@ > /* { dg-do run } */ > -/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms" } */ > +/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1 " } */ > +/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms -mno-update --param sms-min-sc=1 -fmodulo-sched-allow-regmoves " { target powerpc*-*-*} } */ ^ try to avoid superfluous whitespace > + and blank lines. > Index: testsuite/gcc.dg/sms-7.c > =================================================================== > --- testsuite/gcc.dg/sms-7.c (revision 173659) > +++ testsuite/gcc.dg/sms-7.c (working copy) > @@ -1,5 +1,6 @@ > /* { dg-do run } */ > -/* { dg-options "-O2 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms" } */ > +/* { dg-options "-O3 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms -fmodulo-sched-allow-regmoves --param sms-min-sc=1" } */ > +/* { dg-options "-O2 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms --param sms-min-sc=1 -mno-update -fmodulo-sched-allow-regmoves" { target powerpc*-*-*} } */ > > extern void abort (void); > > @@ -44,7 +45,7 @@ int main() > return 0; > } > > -/* { dg-final { scan-rtl-dump-times "SMS succeeded" 1 "sms" { target spu-*-* } } } */ > +/* { dg-final { scan-rtl-dump-times "SMS succeeded" 2 "sms" { target spu-*-* } } } */ > /* { dg-final { scan-rtl-dump-times "SMS succeeded" 3 "sms" { target powerpc*-*-* } } } */ ^ again: one space, two spaces at random? Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University