From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46078 invoked by alias); 14 Jun 2019 06:59:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46068 invoked by uid 89); 14 Jun 2019 06:59:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1330 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jun 2019 06:59:04 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 2EEAEBF9; Fri, 14 Jun 2019 08:59:02 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ktXvfHfjbuuu; Fri, 14 Jun 2019 08:59:00 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACF410.dip0.t-ipconnect.de [84.172.244.16]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 29B74BF8; Fri, 14 Jun 2019 08:59:00 +0200 (CEST) From: Rainer Orth To: Jan Hubicka Cc: Christophe Lyon , Richard Biener , gcc Patches , d@dcepelik.cz Subject: Re: indirect_ref_may_alias_decl_p fix References: <20190613120550.7wtzpieeszazjn7i@kam.mff.cuni.cz> <20190613122928.arp65f726mbnsxyz@kam.mff.cuni.cz> <20190613211524.2b7cfu2ha46zpj4n@kam.mff.cuni.cz> Date: Fri, 14 Jun 2019 06:59:00 -0000 In-Reply-To: <20190613211524.2b7cfu2ha46zpj4n@kam.mff.cuni.cz> (Jan Hubicka's message of "Thu, 13 Jun 2019 23:15:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00813.txt.bz2 Hi Jan, > I am testing the following patch which solves the bogus warning in > tree-ssa-forwprop.c and -m32 and plan to commit it as obvoius to unbreak > bootstrap once testing converges. Previously we did not get here wince > we got mismatch between TMR type and decl type but same code is present > in indirect_ref_may_alias_p. > > Honza > > PR bootstrap/90873 > * tree-ssa-alias.c (indirect_ref_may_alias_decl_p): Also check that > dbase is not TARGET_MEM_REF. I've included the patch in nightly bootstraps on i386-pc-solaris2.11, sparc-sun-solaris2.11, and i686-pc-linux-gnu. All completed without regressions, thanks. One last issue, though. The error messages totally feel like line noise to me: /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-forwprop.c: In function 'bool simplify_rotate(gimple_stmt_iterator*)': /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-forwprop.c:1650:40: error: '#'target_mem_ref' not supported by dump_expr#' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1650 | if (cdef_arg2[i] == def_arg2[1 - i] | ~~~~~~~~~~~~~~^ Is this really something we mean to expose to users? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University