From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Handle pairs of complex+simple blocks and empty blocks more gracefully
Date: Fri, 11 Sep 2015 08:53:00 -0000 [thread overview]
Message-ID: <yddr3m5bap3.fsf@lokon.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <55F197EB.3010404@arm.com> (Kyrill Tkachov's message of "Thu, 10 Sep 2015 15:47:07 +0100")
Kyrill Tkachov <kyrylo.tkachov@arm.com> writes:
> On 10/09/15 12:43, Rainer Orth wrote:
>> Hi Kyrill,
>>
>>> Rainer, could you please check that this patch still fixes the SPARC
>>> regressions?
>> unfortunately, it breaks sparc-sun-solaris2.10 bootstrap: compiling
>> stage2 libiberty/regex.c FAILs:
>>
>>
>
> Thanks for providing the preprocessed file.
> I've reproduced and fixed the ICE in this version of the patch.
> The problem was that I was taking the mode of x before the check
> of whether a and b are MEMs, after which we would change x to an
> address_mode reg,
> thus confusing emit_move_insn.
>
> The fix is to take the mode of x and perform the can_conditionally_move_p check
> after that transformation.
>
> Bootstrapped and tested on aarch64 and x86_64.
> The preprocessed regex.i that Rainer provided now compiles successfully for me
> on a sparc-sun-solaris2.10 stage-1 cross-compiler.
>
> Rainer, thanks for your help so far, could you please try out this patch?
While bootstrap succeeds again, the testsuite regression in
gcc.c-torture/execute/20071216-1.c reoccured.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2015-09-11 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 8:23 Kyrill Tkachov
2015-09-10 11:57 ` Rainer Orth
2015-09-10 13:18 ` Kyrill Tkachov
2015-09-10 14:52 ` Kyrill Tkachov
2015-09-11 8:53 ` Rainer Orth [this message]
2015-09-11 15:43 ` Kyrill Tkachov
2015-09-17 12:02 ` Rainer Orth
2015-09-17 16:36 ` Kyrill Tkachov
2015-09-18 9:24 ` Rainer Orth
2015-09-25 11:20 ` Rainer Orth
2015-09-25 11:21 ` Kyrill Tkachov
2015-09-25 20:32 ` Jeff Law
2015-09-28 9:43 ` Kyrill Tkachov
2015-09-28 17:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddr3m5bap3.fsf@lokon.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).