From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Arthur Cohen <arthur.cohen@embecosm.com>
Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Subject: Re: [COMMITTED] rust_debug: Cast size_t values to unsigned long before printing.
Date: Thu, 18 Jan 2024 10:34:50 +0100 [thread overview]
Message-ID: <yddttnb3ryd.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <7b53ee9e-1830-4878-9e12-b3e748a2e4fd@embecosm.com> (Arthur Cohen's message of "Thu, 18 Jan 2024 11:30:49 +0100")
Hi Arthur,
> Yes, I was talking about this on IRC the other day - if we do run in a
> situation where we have more than UINT32_MAX procedural macros in memory
> we have big issues. These debug prints will probably end up getting removed
> soon as they clutter the output a lot for little information.
makes sense, especially if they break the build once in a while ;-)
> I don't mind doing it the right way for our regular prints, but we have not
> been using PRIu64 in our codebase so far, so I'd rather change all those
> incriminating format specifiers at once later down the line - this patch
> was pushed so that 32bit targets could bootstrap the Rust frontend for now.
Makes sense: using different styles throughout the codebase only creates
confusion.
On a related issue: didn't you have some 32-bit host in your CI? I
remember having similar issues in the past which could easily be avoided
in advance this way.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2024-01-18 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 9:00 Arthur Cohen
2024-01-18 9:13 ` Rainer Orth
2024-01-18 10:30 ` Arthur Cohen
2024-01-18 9:34 ` Rainer Orth [this message]
2024-01-18 20:19 ` Arthur Cohen
2024-01-18 11:02 ` Iain Sandoe
2024-01-18 20:21 ` Arthur Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddttnb3ryd.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).