From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7303 invoked by alias); 24 Oct 2014 09:32:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7292 invoked by uid 89); 24 Oct 2014 09:32:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,T_TVD_MIME_NO_HEADERS autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Oct 2014 09:32:11 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 4F3B4676; Fri, 24 Oct 2014 11:32:09 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id UvADufd+chRX; Fri, 24 Oct 2014 11:32:06 +0200 (CEST) Received: from fuego.CeBiTec.Uni-Bielefeld.DE (p54879C85.dip0.t-ipconnect.de [84.135.156.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 681BF675; Fri, 24 Oct 2014 11:32:06 +0200 (CEST) From: Rainer Orth To: Jakub Jelinek Cc: Uros Bizjak , Kirill Yukhin , gcc-patches@gcc.gnu.org, Eric Botcazou Subject: Re: [PATCH] Fix and improve avx2 broadcasts (PR target/63594) References: <20141021161037.GA10376@tucnak.redhat.com> <20141023131305.GL10376@tucnak.redhat.com> Date: Fri, 24 Oct 2014 09:35:00 -0000 In-Reply-To: (Rainer Orth's message of "Thu, 23 Oct 2014 15:20:32 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02504.txt.bz2 --=-=-= Content-length: 1123 Rainer Orth writes: > Jakub Jelinek writes: > >> On Thu, Oct 23, 2014 at 02:58:06PM +0200, Rainer Orth wrote: >>> Unfortunately, I see some problems with those tests on Solaris: >>> >>> * On Solaris/x86, I get >>> >>> FAIL: gcc.dg/pr63594-2.c execution test >>> >>> for 32-bit. Any particular reason to restrict -mno-mmx to Linux/x86? >>> Manually building the testcase with -mno-mmx on Solaris/x86 seems to >>> cure the failure. >> >> No reason, probably finger memory without lots of thinking. >> The reason for -mno-mmx is that the functions use floating point vectors >> and scalar floating point arithmetics in the same function. >> Feel free to change both pr63594-{1,2}.c with s/linux//g . > > Ok, will do and commit after Linux and Solaris testing. Here's what I've checked in after i686-unknown-linux-gnu, x86_64-unknown-linux-gnu, and i386-pc-solaris2.11 testing: 2014-10-24 Rainer Orth * gcc.dg/pr63594-1.c: Apply -mno-mmx to all i?86-*-* and x86_64-*-* targets. * gcc.dg/pr63594-2.c: Likewise. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=pr63594.patch Content-length: 911 diff --git a/gcc/testsuite/gcc.dg/pr63594-1.c b/gcc/testsuite/gcc.dg/pr63594-1.c --- a/gcc/testsuite/gcc.dg/pr63594-1.c +++ b/gcc/testsuite/gcc.dg/pr63594-1.c @@ -1,7 +1,7 @@ /* PR target/63594 */ /* { dg-do compile } */ /* { dg-options "-O2 -Wno-psabi" } */ -/* { dg-additional-options "-mno-mmx" { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-additional-options "-mno-mmx" { target i?86-*-* x86_64-*-* } } */ #define C1 c #define C2 C1, C1 diff --git a/gcc/testsuite/gcc.dg/pr63594-2.c b/gcc/testsuite/gcc.dg/pr63594-2.c --- a/gcc/testsuite/gcc.dg/pr63594-2.c +++ b/gcc/testsuite/gcc.dg/pr63594-2.c @@ -1,7 +1,7 @@ /* PR target/63594 */ /* { dg-do run } */ /* { dg-options "-O2 -Wno-psabi" } */ -/* { dg-additional-options "-mno-mmx" { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-additional-options "-mno-mmx" { target i?86-*-* x86_64-*-* } } */ #define C1 c #define C2 C1, C1 --=-=-= Content-length: 1277 >>> * On 64-bit Solaris/SPARC, I get >>> >>> FAIL: gcc.dg/pr63594-1.c (internal compiler error) >>> FAIL: gcc.dg/pr63594-1.c (test for excess errors) >>> >>> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/pr63594-1.c: In function >>> 'test1float1': >>> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/pr63594-1.c:19:1: >>> internal compiler error: Bus Error >>> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/pr63594-1.c:57:1: note: >>> in expansion of macro 'T' >>> 0x751c03 crash_signal >>> /vol/gcc/src/hg/trunk/local/gcc/toplev.c:349 >>> 0x44ffb4 gen_group_rtx(rtx_def*) >>> /vol/gcc/src/hg/trunk/local/gcc/expr.c:1624 >>> 0x4f8167 expand_function_start(tree_node*) >>> /vol/gcc/src/hg/trunk/local/gcc/function.c:4803 >>> 0x36278f execute >>> /vol/gcc/src/hg/trunk/local/gcc/cfgexpand.c:5709 >> >> Works fine on x86_64, and doesn't seem to be related to the fix in any way, >> it seems the ICE is related to returning or passing the vectors, so >> supposedly some latent Solaris/SPARC issue? > > Ok, I'll file a PR and Cc Eric. This seems to be the same issue as PR target/61535. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-=--