[testsuite, lto] Fix gcc.dg/lto/20100423-2 tests

[testsuite, lto] Fix gcc.dg/lto/20100423-2 tests

[Rainer Orth]

Recently, a couple of testsuite regressions appeared:

+FAIL: gcc.dg/lto/20100423-2 c_lto_20100423-2_0.o-c_lto_20100423-2_1.o link
+UNRESOLVED: gcc.dg/lto/20100423-2 c_lto_20100423-2_0.o-c_lto_20100423-2_1.o exe
cute -O2 -flto

Undefined			first referenced
 symbol  			    in file
stderr                              c_lto_20100423-2_0.o
ld: fatal: symbol referencing errors. No output written to gcc-dg-lto-20100423-2-01

Obviously, the test depends on the internals of GLIBC stdio.  Easily
fixed by including <stdio.h> instead, but this exposes another error in
64-bit testing:

output is:
/vol/gcc/src/hg/trunk/solaris/gcc/testsuite/gcc.dg/lto/20100423-2_0.c:6:22: error: conflicting types for 'size_t'
/usr/include/iso/stdio_iso.h:97:23: note: previous declaration of 'size_t' was here

Bootstrapped on i386-pc-solaris2.11.

Ok for mainline?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2010-05-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/lto/20100423-2_0.c: Include <stdio.h>.
	(size_t, stderr): Remove.

Fix gcc.dg/lto/20100423-2 tests

diff -r ed74734b74ef gcc/testsuite/gcc.dg/lto/20100423-2_0.c
--- a/gcc/testsuite/gcc.dg/lto/20100423-2_0.c	Mon May 03 21:35:04 2010 +0200
+++ b/gcc/testsuite/gcc.dg/lto/20100423-2_0.c	Mon May 03 21:36:07 2010 +0200
@@ -1,8 +1,8 @@
 /* { dg-lto-do link } */
 /* { dg-lto-options {{-O2 -flto} {-O2 -fwhopr} {-O3 -flto} {-O3 -fwhopr}} } */
 
-typedef unsigned int size_t;
-extern struct _IO_FILE *stderr;
+#include <stdio.h>
+
 typedef unsigned char uch;
 extern uch inbuf[];
 unsigned insize;

Re: [testsuite, lto] Fix gcc.dg/lto/20100423-2 tests

[Richard Guenther]

On Mon, May 3, 2010 at 9:40 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> Recently, a couple of testsuite regressions appeared:
>
> +FAIL: gcc.dg/lto/20100423-2 c_lto_20100423-2_0.o-c_lto_20100423-2_1.o link
> +UNRESOLVED: gcc.dg/lto/20100423-2 c_lto_20100423-2_0.o-c_lto_20100423-2_1.o exe
> cute -O2 -flto
>
> Undefined                       first referenced
>  symbol                             in file
> stderr                              c_lto_20100423-2_0.o
> ld: fatal: symbol referencing errors. No output written to gcc-dg-lto-20100423-2-01
>
> Obviously, the test depends on the internals of GLIBC stdio.  Easily
> fixed by including <stdio.h> instead, but this exposes another error in
> 64-bit testing:
>
> output is:
> /vol/gcc/src/hg/trunk/solaris/gcc/testsuite/gcc.dg/lto/20100423-2_0.c:6:22: error: conflicting types for 'size_t'
> /usr/include/iso/stdio_iso.h:97:23: note: previous declaration of 'size_t' was here
>
> Bootstrapped on i386-pc-solaris2.11.
>
> Ok for mainline?

Can you then also exchange the call to __builtin_fprintf to fprintf?

Ok with that change.
Thanks,
Richard.

>        Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2010-05-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        * gcc.dg/lto/20100423-2_0.c: Include <stdio.h>.
>        (size_t, stderr): Remove.
>
> Fix gcc.dg/lto/20100423-2 tests
>
> diff -r ed74734b74ef gcc/testsuite/gcc.dg/lto/20100423-2_0.c
> --- a/gcc/testsuite/gcc.dg/lto/20100423-2_0.c   Mon May 03 21:35:04 2010 +0200
> +++ b/gcc/testsuite/gcc.dg/lto/20100423-2_0.c   Mon May 03 21:36:07 2010 +0200
> @@ -1,8 +1,8 @@
>  /* { dg-lto-do link } */
>  /* { dg-lto-options {{-O2 -flto} {-O2 -fwhopr} {-O3 -flto} {-O3 -fwhopr}} } */
>
> -typedef unsigned int size_t;
> -extern struct _IO_FILE *stderr;
> +#include <stdio.h>
> +
>  typedef unsigned char uch;
>  extern uch inbuf[];
>  unsigned insize;
>

Re: [testsuite, lto] Fix gcc.dg/lto/20100423-2 tests

[Rainer Orth]

Richard Guenther <richard.guenther@gmail.com> writes:

> Can you then also exchange the call to __builtin_fprintf to fprintf?

Sure: retested and installed.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University