From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Ian Lance Taylor <iant@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)
Date: Thu, 21 Nov 2019 00:46:00 -0000 [thread overview]
Message-ID: <yddv9revz5g.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20191121001845.GC4650@tucnak> (Jakub Jelinek's message of "Thu, 21 Nov 2019 01:18:45 +0100")
Hi Jakub,
> On Tue, Nov 05, 2019 at 05:17:10PM +0000, Wilco Dijkstra wrote:
>> Passes bootstrap and regress on AArch64 and x64. OK for commit?
>
> This broke bootstrap on x86_64-linux as well as i686-linux (guess all
> targets that go supports).
indeed: just saw it on Solaris with the native ld.
> The following patch fixes it for me, though not sure which *.c file is best
> and what location in there for the definition.
I've placed it in runtime/go-unwind.c: probestackmaps is defined there
which is declared close to runtime_usestackmaps.
> With this bootstrap succeeded on both x86_64-linux and i686-linux, regtest
> is still pending, but without it it just failed to link libgo.
Same on sparc-sun-solaris2.11 and i386-pc-solaris2.11.
There where quite a number of non-Go regressions all over the place.
Many are like this:
FAIL: gcc.c-torture/execute/complex-6.c -O0 (test for excess errors)
ld: warning: symbol 'err' has differing types:
(file /var/tmp//ccWQCyMc.o type=OBJT; file /lib/libc.so type=FUNC);
/var/tmp//ccWQCyMc.o definition taken
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2019-11-21 0:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 16:00 [PATCH] PR85678: Change default to -fno-common Wilco Dijkstra
2019-10-25 19:11 ` Georg-Johann Lay
2019-10-26 12:45 ` Iain Sandoe
2019-10-26 13:27 ` Segher Boessenkool
2019-10-25 22:44 ` Segher Boessenkool
2019-10-26 18:21 ` Jeff Law
2019-10-28 16:15 ` Wilco Dijkstra
2019-10-28 18:44 ` Segher Boessenkool
2019-10-27 5:58 ` Harald van Dijk
2019-10-29 13:06 ` [PATCH v2] " Wilco Dijkstra
2019-10-30 14:10 ` Richard Biener
2019-10-30 14:33 ` Wilco Dijkstra
2019-11-04 13:39 ` Richard Biener
2019-11-04 14:39 ` Wilco Dijkstra
2019-11-05 12:25 ` Richard Biener
2019-11-05 17:17 ` [PATCH v3] " Wilco Dijkstra
2019-11-17 23:35 ` Jeff Law
2019-11-21 0:41 ` [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common) Jakub Jelinek
2019-11-21 0:46 ` Rainer Orth [this message]
2019-11-21 1:04 ` Jakub Jelinek
2019-11-21 11:40 ` Rainer Orth
2019-11-21 11:40 ` Jakub Jelinek
2019-11-21 11:54 ` Wilco Dijkstra
2019-11-21 11:58 ` Jakub Jelinek
2019-11-21 1:11 ` Ian Lance Taylor
2019-11-29 13:17 ` [PATCH] PR85678: Change default to -fno-common Martin Liška
2019-11-29 14:46 ` Wilco Dijkstra
2019-11-29 15:09 ` Martin Liška
2019-12-01 4:17 ` Jeff Law
2019-12-04 15:26 ` Wilco Dijkstra
2019-12-04 17:27 ` Jeff Law
2019-12-04 21:03 ` Joseph Myers
2019-12-04 21:14 ` Jeff Law
2019-12-05 9:16 ` Martin Liška
2019-12-05 10:01 ` Tobias Burnus
2019-12-05 13:18 ` Wilco Dijkstra
2019-12-05 16:49 ` Jeff Law
2019-12-05 15:40 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddv9revz5g.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).