From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97120 invoked by alias); 12 Aug 2016 09:15:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 97111 invoked by uid 89); 12 Aug 2016 09:15:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Neither, Bielefeld, Biotechnology, bielefeld X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Aug 2016 09:15:21 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id F0ED1F24; Fri, 12 Aug 2016 11:15:18 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CNR6J24ORAZ4; Fri, 12 Aug 2016 11:15:16 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 81D37F22; Fri, 12 Aug 2016 11:15:16 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id u7C9FGV4009358; Fri, 12 Aug 2016 11:15:16 +0200 (CEST) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches , "gofrontend-dev\@googlegroups.com" Subject: Re: libgo patch committed: Change build procedure to use build tags References: Date: Fri, 12 Aug 2016 09:15:00 -0000 In-Reply-To: (Ian Lance Taylor's message of "Thu, 11 Aug 2016 14:36:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg01001.txt.bz2 Hi Ian, >> this patch broke i386-pc-solaris2.12 and sparc-sun-solaris2.12 >> bootstrap, however: in both cases, the 64-bit build of os.lo fails like this: >> >> /vol/gcc/src/hg/trunk/local/libgo/go/os/dir.go:82:8: error: reference to undefined name 'libc_readdir_r' >> i := libc_readdir_r(file.dirinfo.dir, entryDirent, pr) >> ^ >> >> Neither dir_largefile.go (which is correctly omitted, being 32-bit only) >> nor dir_regfile.go (which is needed here) is included in the >> compilation. > > Sorry, I don't know what I messed up in my testing. I committed the > appended patch, which should fix the problem. I had found a different one to the same effect, but running match.sh with yours looked right, too. There's now one new failure, 32 and 64-bit, sparc and x86: +FAIL: syscall libgo.log shows libcalls.go:825:1: error: redefinition of 'Getpgid' func Getpgid(pid int) (pgid int, err error) { ^ exec_solaris_test.go:22:1: note: previous definition of 'Getpgid' was here func Getpgid(pid int) (pgid int, err error) { ^ libcalls.go:843:1: error: redefinition of 'Getpgrp' func Getpgrp() (pid int) { ^ exec_solaris_test.go:31:1: note: previous definition of 'Getpgrp' was here func Getpgrp() (pgrp int) { ^ exec_solaris_test.go:14:3: error: libc_Getpgid is not a function; //go:linkname is only supported for functions //go:linkname libc_Getpgid libc_Getpgid ^ exec_solaris_test.go:15:3: error: libc_Getpgrp is not a function; //go:linkname is only supported for functions //go:linkname libc_Getpgrp libc_Getpgrp ^ exec_solaris_test.go:23:15: error: reference to undefined name 'sysvicall6' r0, _, e1 := sysvicall6(uintptr(unsafe.Pointer(&libc_Getpgid)), 1, uintptr(pid), 0, 0, 0, 0, 0) ^ exec_solaris_test.go:32:14: error: reference to undefined name 'sysvicall6' r0, _, _ := sysvicall6(uintptr(unsafe.Pointer(&libc_Getpgrp)), 0, 0, 0, 0, 0, 0, 0) ^ exec_solaris_test.go:37:13: error: reference to undefined name 'ioctl' var Ioctl = ioctl ^ exec_solaris_test.go:19:15: error: use of undefined type 'libcFunc' libc_Getpgrp libcFunc ^ I've no idea what exec_solaris_test.go is about: e.g.I couldn't find any other reference to sysvicall6 elsewhere in the gcc tree. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University