* [testsuite] Remove dg-excess-errors in gcc.dg/inline_[34].c and unroll_[234].c
@ 2013-02-26 10:31 Dominique Dhumieres
2013-03-11 10:14 ` Rainer Orth
0 siblings, 1 reply; 2+ messages in thread
From: Dominique Dhumieres @ 2013-02-26 10:31 UTC (permalink / raw)
To: gcc-patches; +Cc: iain, mikestump, davidxl, ro
The following tests XPASS on i?86-*-linux* and x86_64-*-linux* (see,
e.g., http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg02923.html )
XPASS: gcc.dg/inline_3.c (test for excess errors)
XPASS: gcc.dg/inline_4.c (test for excess errors)
XPASS: gcc.dg/unroll_2.c (test for excess errors)
XPASS: gcc.dg/unroll_3.c (test for excess errors)
XPASS: gcc.dg/unroll_4.c (test for excess errors)
The following patch fixes this to remove the noise. In addition I do not
see why this tests should be restricted to i?86-*-linux* and
x86_64-*-linux* (the other tests inline_[12].c and unroll_[15] have no
restrictions). Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10.
Ok for mainline? If yes, could someone commit the patch since I don't have
write access?
Dominique
2013-02-26 Dominique d'Humieres <dominiq@lps.ens.fr>
* gcc.dg/inline_3.c: Remove target and dg-excess-errors.
* gcc.dg/inline_4.c: Likewise.
* gcc.dg/unroll_2.c: Likewise.
* gcc.dg/unroll_3.c: Likewise.
* gcc.dg/unroll_4.c: Likewise.
--- ../_clean/gcc/testsuite/gcc.dg/inline_3.c 2011-06-21 09:13:05.000000000 +0200
+++ gcc/testsuite/gcc.dg/inline_3.c 2013-02-03 19:25:05.000000000 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo,foo2 -fdisable-ipa-inline -Wno-attributes" } */
int g;
__attribute__((always_inline)) void bar (void)
@@ -20,4 +20,3 @@ int foo2 (void)
/* { dg-final { scan-tree-dump-times "bar" 5 "optimized" } } */
/* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/inline_4.c 2011-06-21 09:13:05.000000000 +0200
+++ gcc/testsuite/gcc.dg/inline_4.c 2013-02-03 19:25:20.000000000 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo2 -fdisable-ipa-inline -Wno-attributes" } */
int g;
__attribute__((always_inline)) void bar (void)
@@ -20,4 +20,3 @@ int foo2 (void)
/* { dg-final { scan-tree-dump-times "bar" 4 "optimized" } } */
/* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_2.c 2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_2.c 2013-02-03 19:25:43.000000000 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll=foo -fdisable-tree-cunrolli=foo -fenable-rtl-loop2_unroll" } */
unsigned a[100], b[100];
@@ -30,4 +30,3 @@ int foo2(void)
/* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
/* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_3.c 2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_3.c 2013-02-03 19:25:55.000000000 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll -fdisable-tree-cunrolli -fenable-rtl-loop2_unroll=foo" } */
unsigned a[100], b[100];
@@ -30,4 +30,3 @@ int foo2(void)
/* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
/* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_4.c 2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_4.c 2013-02-03 19:26:10.000000000 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll -fdisable-tree-cunrolli -fenable-rtl-loop2_unroll=foo2" } */
unsigned a[100], b[100];
@@ -30,4 +30,3 @@ int foo2(void)
/* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
/* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [testsuite] Remove dg-excess-errors in gcc.dg/inline_[34].c and unroll_[234].c
2013-02-26 10:31 [testsuite] Remove dg-excess-errors in gcc.dg/inline_[34].c and unroll_[234].c Dominique Dhumieres
@ 2013-03-11 10:14 ` Rainer Orth
0 siblings, 0 replies; 2+ messages in thread
From: Rainer Orth @ 2013-03-11 10:14 UTC (permalink / raw)
To: Dominique Dhumieres; +Cc: gcc-patches, iain, mikestump, davidxl
dominiq@lps.ens.fr (Dominique Dhumieres) writes:
> The following tests XPASS on i?86-*-linux* and x86_64-*-linux* (see,
> e.g., http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg02923.html )
>
> XPASS: gcc.dg/inline_3.c (test for excess errors)
> XPASS: gcc.dg/inline_4.c (test for excess errors)
> XPASS: gcc.dg/unroll_2.c (test for excess errors)
> XPASS: gcc.dg/unroll_3.c (test for excess errors)
> XPASS: gcc.dg/unroll_4.c (test for excess errors)
>
> The following patch fixes this to remove the noise. In addition I do not
> see why this tests should be restricted to i?86-*-linux* and
> x86_64-*-linux* (the other tests inline_[12].c and unroll_[15] have no
> restrictions). Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10.
>
> Ok for mainline? If yes, could someone commit the patch since I don't have
> write access?
I've now tested the patch on x86_64-unknown-linux-gnu and
i686-unknown-linux-gnu where it removes the XPASSes (thus less testsuite
noise), and on {i386-pc,sparc-sun}-solaris2.{9,10,11} where the tests
pass, too.
Unless the release managers object, I plan to commit it later today.
Thanks and sorry for the delay.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 10:31 [testsuite] Remove dg-excess-errors in gcc.dg/inline_[34].c and unroll_[234].c Dominique Dhumieres
2013-03-11 10:14 ` Rainer Orth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).