From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3040 invoked by alias); 1 Jul 2011 13:37:59 -0000 Received: (qmail 3030 invoked by uid 22791); 1 Jul 2011 13:37:59 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jul 2011 13:37:44 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 259EBB3C; Fri, 1 Jul 2011 15:37:43 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jQ+-XCupFlU1; Fri, 1 Jul 2011 15:37:41 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id A4F20B3B; Fri, 1 Jul 2011 15:37:41 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p61DbeYY026440; Fri, 1 Jul 2011 15:37:40 +0200 (MEST) From: Rainer Orth To: "H.J. Lu" Cc: Richard Henderson , Jason Merrill , gcc-patches@gcc.gnu.org, Jakub Jelinek Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *) References: <20110625161357.GA5401@intel.com> <4E078E58.20903@redhat.com> <4E07A879.70509@redhat.com> <4E089A88.60401@redhat.com> <4E0C8361.5050403@redhat.com> <4E0C904E.8090504@redhat.com> <4E0CC85E.3090401@redhat.com> Date: Fri, 01 Jul 2011 13:37:00 -0000 In-Reply-To: (H. J. Lu's message of "Fri, 1 Jul 2011 05:50:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00034.txt.bz2 "H.J. Lu" writes: > On Fri, Jul 1, 2011 at 2:02 AM, Rainer Orth = wrote: >> "H.J. Lu" writes: >> >>> Here is the updated patch. =A0It works on simple tests. >>> I am running full tests. =A0I kept config/i386/value-unwind.h >>> since libgcc/md-unwind-support.h is included too late >>> in unwind-dw2.c and I don't want to move it to be on >>> the safe side. >> >> Oh please, don't pile hack upon hack to avoid proper testing. >> > > What is your suggestion? How about moving the md-unwind-support.h include up to the rest of the includes? The headers usually only define MD_FALLBACK_FRAME_STATE_FOR and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal helper macro, so order shouldn't matter. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University