From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65670 invoked by alias); 9 Oct 2018 09:04:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65656 invoked by uid 89); 9 Oct 2018 09:04:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=badly X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 09:03:57 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 966B6790; Tue, 9 Oct 2018 11:03:54 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZuezXuCYZz0n; Tue, 9 Oct 2018 11:03:52 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id BAF8C78F; Tue, 9 Oct 2018 11:03:52 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w9993oI1005974; Tue, 9 Oct 2018 11:03:50 +0200 (MEST) From: Rainer Orth To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: Uros Bizjak , Jakub Jelinek , Richard Earnshaw , Richard Guenther , renlin.li@foss.arm.com, "gcc-patches\@gcc.gnu.org" Subject: Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests. References: <70b0358c-5060-b5c0-9116-3b4e8e0b5146@suse.cz> <2a8a2cc1-1677-9d42-f2c9-973068b7eba2@foss.arm.com> <3e330d0a-e823-28c7-dcb7-d7121ece34f9@arm.com> <7ce332a1-cdc5-e562-818c-cab068bd0972@arm.com> <0383b55e-4108-4e9f-dfbc-eca831b9e1b9@suse.cz> <20181008112152.GG11625@tucnak> <01e76da0-6e9e-c8f4-4579-60a349e6e8f9@suse.cz> Date: Tue, 09 Oct 2018 10:06:00 -0000 In-Reply-To: ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Tue, 9 Oct 2018 10:53:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00495.txt.bz2 Hi Martin, > rename from gcc/testsuite/g++.dg/ext/pr82625.C > rename to gcc/testsuite/g++.target/i386/pr82625.C > index 59b174f8c51..0eb70baed5e 100644 > --- a/gcc/testsuite/g++.dg/ext/pr82625.C > +++ b/gcc/testsuite/g++.target/i386/pr82625.C > @@ -1,7 +1,7 @@ > /* { dg-do compile } */ > /* { dg-require-ifunc "" } */ > /* { dg-options "-O2 -fdump-tree-optimized" } */ > -/* { dg-do compile { target i?86-*-* x86_64-*-* } } */ > +/* { dg-do compile } */ this is wrong: two instances of dg-do and dg-do after target selections don't play well with one another. When you added it yesterday, you badly broke the test on all x86 targets without ifunc support (probably everything non-Linux): +UNRESOLVED: g++.dg/ext/pr82625.C -std=gnu++11 scan-tree-dump-times optimized "return 4096;" 1 +UNRESOLVED: g++.dg/ext/pr82625.C -std=gnu++11 scan-tree-dump-times optimized "return 8192;" 1 +FAIL: g++.dg/ext/pr82625.C -std=gnu++11 (test for excess errors) Excess errors: /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/pr82625.C:7:17: error: multiversioning needs ifunc which is not supported on this target /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/pr82625.C:24:1: error: use of multiversioned function without a default Just remove the second dg-do line. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University