* Unreviewed build patches
@ 2011-05-19 11:01 Rainer Orth
2011-05-21 11:46 ` DJ Delorie
0 siblings, 1 reply; 4+ messages in thread
From: Rainer Orth @ 2011-05-19 11:01 UTC (permalink / raw)
To: gcc-patches; +Cc: Paolo Bonzini, Ralf Wildenhues
The following two build-related patches have remained unreviewed for 2
or more weeks:
[build, lto] Check plugin linker for level of plugin support
http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00226.html
Embedded in a different thread, but reminded 4 times now and all open
questions answered AFAICT.
[build] More --enable-threads cleanup
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html
This might well be obvious.
Besides, it would be helpful if a build maintainer could have a look at
[build] Move Solaris 2 startup files to toplevel libgcc
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00098.html
either to state that I don't need approval or to make suggestings for
improvements. This is not yet the final patch, but the remainder is
tuning.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed build patches
2011-05-19 11:01 Unreviewed build patches Rainer Orth
@ 2011-05-21 11:46 ` DJ Delorie
2011-05-23 14:30 ` Rainer Orth
0 siblings, 1 reply; 4+ messages in thread
From: DJ Delorie @ 2011-05-21 11:46 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, bonzini, Ralf.Wildenhues
> [build] More --enable-threads cleanup
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html
>
> This might well be obvious.
Also, we usually leave those up to the target maintainers, since
they're target specific. But if it's just a correlation between the
script and a list of source file options, go for it.
> Besides, it would be helpful if a build maintainer could have a look at
>
> [build] Move Solaris 2 startup files to toplevel libgcc
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00098.html
>
> either to state that I don't need approval or to make suggestings for
> improvements. This is not yet the final patch, but the remainder is
> tuning.
We normally let target maintainers manage anything in the build that's
target-specific. However, you've mixed in target patches with
target-independent patches. I have no problem with you checking in
your own target changes, but if you could split out the rest for
review, it would make it easier on us.
Also, mention if you tested it on any ix86 non-solaris platform
(linux, bsd, etc).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed build patches
2011-05-21 11:46 ` DJ Delorie
@ 2011-05-23 14:30 ` Rainer Orth
2011-05-23 19:08 ` DJ Delorie
0 siblings, 1 reply; 4+ messages in thread
From: Rainer Orth @ 2011-05-23 14:30 UTC (permalink / raw)
To: DJ Delorie; +Cc: gcc-patches, bonzini, Ralf.Wildenhues
DJ Delorie <dj@redhat.com> writes:
>> [build] More --enable-threads cleanup
>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html
>>
>> This might well be obvious.
>
> Also, we usually leave those up to the target maintainers, since
> they're target specific. But if it's just a correlation between the
True, but finding maintainers for obsolete/removed ports might be
difficult :-)
> script and a list of source file options, go for it.
I did, thanks.
>> Besides, it would be helpful if a build maintainer could have a look at
>>
>> [build] Move Solaris 2 startup files to toplevel libgcc
>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00098.html
>>
>> either to state that I don't need approval or to make suggestings for
>> improvements. This is not yet the final patch, but the remainder is
>> tuning.
>
> We normally let target maintainers manage anything in the build that's
> target-specific. However, you've mixed in target patches with
I know and usually act on that rule. I wasn't asking so much for
approval but rather for suggestions for the build side of things.
> target-independent patches. I have no problem with you checking in
> your own target changes, but if you could split out the rest for
> review, it would make it easier on us.
I can try if the build maintainers need that. So far, I can only see
use of the new generic libgcc/config/t-crtfm on sparc targets other
than Solaris, and $< instead of pathnames in libgcc/config/i386/t-crtfm,
gld detection and substitution of cpu_type.
> Also, mention if you tested it on any ix86 non-solaris platform
> (linux, bsd, etc).
I didn't since apart from the t-crtfm stuff (which has been tested on
Solaris already), there's nothing that could affect them.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed build patches
2011-05-23 14:30 ` Rainer Orth
@ 2011-05-23 19:08 ` DJ Delorie
0 siblings, 0 replies; 4+ messages in thread
From: DJ Delorie @ 2011-05-23 19:08 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, bonzini, Ralf.Wildenhues
> there's nothing that could affect them.
Famous last words :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-23 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 11:01 Unreviewed build patches Rainer Orth
2011-05-21 11:46 ` DJ Delorie
2011-05-23 14:30 ` Rainer Orth
2011-05-23 19:08 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).