From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 1567C3858D37 for ; Mon, 4 Mar 2024 16:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1567C3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1567C3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709569124; cv=none; b=gIGOUM8sl3GPvu8/nH+syR/z1tOiigK8T0qwqnM9tL5iCV7b3+3/lQRS8i12dLXcYY26Twkp0CQuYskaoLmFMl3liOwUuS6pffaPmt6ExeS1fcaf8FDtQUP61PfUch9YAeoy+dBdQdpgSiu4cHtfVoaGibUgdv7/9GLAiigYiYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709569124; c=relaxed/simple; bh=8okmkMnOrVQDO4+xx15TAu1JzgLnN3rm0vk8QRnkKDg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HLbEbZ9K3JPE9nq/pDwWztUPGq/JiskOoETskAjZh6ADi/lncjWlKMhMQT1n5WmGABDwEnT6IrXr2DoeYA55GKe/NUO39MHbAPGlYfQNXNbBxg8dRBC+X52Ve44exsRErOlZ6v5pY2FRFoTa8QckBdcV3ZiWaCdWAre2zcAMrXk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id B49A710601; Mon, 4 Mar 2024 17:18:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:in-reply-to:date:date :references:subject:subject:from:from:received:received; s= 20200306; t=1709569120; bh=8okmkMnOrVQDO4+xx15TAu1JzgLnN3rm0vk8Q RnkKDg=; b=BvhwR46Qxo2WQs0zDflVAli/B5p/OdvvyzvIfF+t5pQoUiSRRIDUS SlB7GFxFoQTYm0CRyhpRnDumf0AE/JmWTOLkZr3THvb3X52VRoo/PnXQQaaUUAC0 JpeE12dOZSNiCQwSTXOzPnt04LPMqGydFv8LIszgx6wT0gtFk29TpsDv3ZWIAM8G CJ0FJlB/wcGvp73GP833526670mNXqsLHCPlSJW0UwLfwUgXD7z7/VIWJ/KEmXcr Tyv6tmZPN5N8/QprCY/D77qnkAcuWz5dGjn9zTa61KHZ6sx/Qd4aJ8VD0r1ff4ag U87S1fC1WDR2NitDC8oClR5Sh6kbfx3QQ== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id x3ZsGN_IAaT9; Mon, 4 Mar 2024 17:18:40 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855b30.dip0.t-ipconnect.de [80.133.91.48]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 0CBB5105A0; Mon, 4 Mar 2024 17:18:40 +0100 (CET) From: Rainer Orth To: Jeff Law Cc: Greg McGary , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] combine: Don't simplify paradoxical SUBREG on WORD_REGISTER_OPERATIONS [PR113010] References: <20240227001736.3690294-1-gkm@rivosinc.com> <4a986781-7be8-4e45-a2d7-567d1df58ee3@gmail.com> Date: Mon, 04 Mar 2024 17:18:39 +0100 In-Reply-To: <4a986781-7be8-4e45-a2d7-567d1df58ee3@gmail.com> (Jeff Law's message of "Thu, 29 Feb 2024 21:30:34 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3782.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, > On 2/26/24 17:17, Greg McGary wrote: >> The sign-bit-copies of a sign-extending load cannot be known until runtime on >> WORD_REGISTER_OPERATIONS targets, except in the case of a zero-extending MEM >> load. See the fix for PR112758. >> 2024-02-22 Greg McGary >> PR rtl-optimization/113010 >> * combine.cc (simplify_comparison): Simplify a SUBREG on >> WORD_REGISTER_OPERATIONS targets only if it is a zero-extending >> MEM load. >> * gcc.c-torture/execute/pr113010.c: New test. > I think this is fine for the trunk. I'll do some final testing on it > tomorrow. unfortunately, the patch broke Solaris/SPARC bootstrap (sparc-sun-solaris2.11): /vol/gcc/src/hg/master/local/gcc/combine.cc: In function 'rtx_code simplify_comparison(rtx_code, rtx_def**, rtx_def**)': /vol/gcc/src/hg/master/local/gcc/combine.cc:12101:25: error: '*(unsigned int*)((char*)&inner_mode + offsetof(scalar_int_mode, scalar_int_mode::m_mode))' may be used uninitialized [-Werror=maybe-uninitialized] 12101 | scalar_int_mode mode, inner_mode, tmode; | ^~~~~~~~~~ Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University