public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86
@ 2024-01-24  9:12 Rainer Orth
  2024-02-02  0:09 ` Mike Stump
  0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2024-01-24  9:12 UTC (permalink / raw)
  To: gcc-patches; +Cc: Roger Sayle

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

gcc.target/i386/avx512vl-stv-rotatedi-1.c FAILs on 32-bit Solaris/x86
since its introduction in

commit 4814b63c3c2326cb5d7baa63882da60ac011bd97
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Mon Jul 10 09:04:29 2023 +0100

    i386: Add AVX512 support for STV of SI/DImode rotation by constant.

FAIL: gcc.target/i386/avx512vl-stv-rotatedi-1.c scan-assembler-times vpro[lr]q 29

While the test depends on -mstv, 32-bit Solaris/x86 defaults to
-mstackrealign which is incompatible.

The patch thus specifies -mstv -mno-stackrealign explicitly.

Tested on i386-pc-solaris2.11 and i686-pc-linux-gnu.

Ok for trunk?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2024-01-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	* gcc.target/i386/avx512vl-stv-rotatedi-1.c: Add -mstv
	-mno-stackrealign to dg-options.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: solx86-testsuite-avx512vl-stv-rotatedi-1.patch --]
[-- Type: text/x-patch, Size: 722 bytes --]

# HG changeset patch
# Parent  b787665f90dfbd5be1b00d411675d6fd896f7a9a
testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86

diff --git a/gcc/testsuite/gcc.target/i386/avx512vl-stv-rotatedi-1.c b/gcc/testsuite/gcc.target/i386/avx512vl-stv-rotatedi-1.c
--- a/gcc/testsuite/gcc.target/i386/avx512vl-stv-rotatedi-1.c
+++ b/gcc/testsuite/gcc.target/i386/avx512vl-stv-rotatedi-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile { target ia32 } } */
-/* { dg-options "-O2 -mavx512vl" } */
+/* { dg-options "-O2 -mavx512vl -mstv -mno-stackrealign" } */
 
 unsigned long long rot1(unsigned long long x) { return (x>>1) | (x<<63); }
 unsigned long long rot2(unsigned long long x) { return (x>>2) | (x<<62); }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86
  2024-01-24  9:12 [PATCH] testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86 Rainer Orth
@ 2024-02-02  0:09 ` Mike Stump
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2024-02-02  0:09 UTC (permalink / raw)
  To: Rainer Orth; +Cc: gcc-patches, Roger Sayle

On Jan 24, 2024, at 1:12 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
> 
> gcc.target/i386/avx512vl-stv-rotatedi-1.c FAILs on 32-bit Solaris/x86
> since its introduction in
> 
> commit 4814b63c3c2326cb5d7baa63882da60ac011bd97
> Author: Roger Sayle <roger@nextmovesoftware.com>
> Date:   Mon Jul 10 09:04:29 2023 +0100
> 
>    i386: Add AVX512 support for STV of SI/DImode rotation by constant.
> 
> FAIL: gcc.target/i386/avx512vl-stv-rotatedi-1.c scan-assembler-times vpro[lr]q 29
> 
> While the test depends on -mstv, 32-bit Solaris/x86 defaults to
> -mstackrealign which is incompatible.
> 
> The patch thus specifies -mstv -mno-stackrealign explicitly.
> 
> Tested on i386-pc-solaris2.11 and i686-pc-linux-gnu.
> 
> Ok for trunk?

Ok.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-02  0:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-24  9:12 [PATCH] testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86 Rainer Orth
2024-02-02  0:09 ` Mike Stump

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).