From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27817 invoked by alias); 23 Oct 2014 13:10:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27807 invoked by uid 89); 23 Oct 2014 13:10:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Oct 2014 13:10:37 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 575CE5CF; Thu, 23 Oct 2014 15:10:35 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HPG9ef14uMsc; Thu, 23 Oct 2014 15:10:33 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id A346E5CD; Thu, 23 Oct 2014 15:10:33 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.7+Sun/8.14.7/Submit) id s9NDAVAm003181; Thu, 23 Oct 2014 15:10:31 +0200 (CEST) From: Rainer Orth To: Andreas Schwab Cc: Alan Lawrence , Jeff Law , "gcc-patches\@gcc.gnu.org" Subject: Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c References: <53B1B4FE.7010201@arm.com> <53B1D271.5000405@redhat.com> <53C69926.4050503@arm.com> <53C80023.6000100@arm.com> <5409FBB1.3040509@redhat.com> <541AA89C.9070005@arm.com> <87ppe70wld.fsf@igel.home> Date: Thu, 23 Oct 2014 13:13:00 -0000 In-Reply-To: <87ppe70wld.fsf@igel.home> (Andreas Schwab's message of "Sun, 05 Oct 2014 10:06:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02398.txt.bz2 Andreas Schwab writes: > Alan Lawrence writes: > >> diff --git a/gcc/testsuite/gcc.dg/combine_ashiftrt_1.c >> b/gcc/testsuite/gcc.dg/combine_ashiftrt_1.c >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..90e64fd10dc358f10ad03a90041605bc3ccb7011 >> --- /dev/null >> +++ b/gcc/testsuite/gcc.dg/combine_ashiftrt_1.c >> @@ -0,0 +1,18 @@ >> +/* { dg-do compile {target sparc64*-*-* aarch64*-*-* x86_64-*-* >> powerpc64*-*-*} } */ > > You should check for lp64 instead of matching 64 in target names, to > reject -m32. > >> diff --git a/gcc/testsuite/gcc.dg/combine_ashiftrt_2.c >> b/gcc/testsuite/gcc.dg/combine_ashiftrt_2.c >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..fd6827caed230ea5dd2d6ec4431b11bf826531ea >> --- /dev/null >> +++ b/gcc/testsuite/gcc.dg/combine_ashiftrt_2.c >> @@ -0,0 +1,18 @@ >> +/* { dg-do compile {target arm*-*-* i?86-*-* powerpc-*-* sparc-*-*} } */ > > Likewise, using ilp32 to reject -m64. Right, the current target lists are simply bogus on biarch targets. Alan, what's the reasoning behind your current target lists here? Any reason the test couldn't work elsewhere? If not, it would be way better to introduce a corresponding effective-target keyword than listing particular targets without explanation. This needs to be fixed: the issue is knowns for three weeks now and causes testsuite noise on many platforms. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University