Re: [patch] Separate {OS,CPU}_CPP_BUILTINS macros into C-family and language-independent macros

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

FX <fxcoudert@gmail.com> writes:

Please don't use application/octet-stream for patch attachments, this
makes it considerably harder to cite them.



2010-10-07  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>

	PR fortran/42954
	* cppbuiltin.c (define_target_specific_builtins,
	define_builtin_macro_std): New functions.
	(define_language_independent_builtin_macros): Call
	define_target_specific_builtins

Missing full stop?

	(define_builtin_macros_for_type_sizes): 

Something is weird here: what changed?

Index: gcc/config/alpha/osf5.h
===================================================================
--- gcc/config/alpha/osf5.h	(revision 165065)
+++ gcc/config/alpha/osf5.h	(working copy)
@@ -47,6 +47,7 @@ along with GCC; see the file COPYING3.  
 
 /* Names to predefine in the preprocessor for this target machine.  */
 
+#undef TARGET_OS_CPP_BUILTINS
 #define TARGET_OS_CPP_BUILTINS()			\
     do {						\
 	builtin_define_std ("unix");			\
@@ -63,7 +64,11 @@ along with GCC; see the file COPYING3.  
 	   to be defined for <math.h>.  */		\
         if (LONG_DOUBLE_TYPE_SIZE == 128)		\
           builtin_define ("__X_FLOAT");			\
-							\
+    } while (0)
+
+#undef TARGET_OS_CPP_BUILTINS_CFAMILY
+#define TARGET_OS_CPP_BUILTINS_CFAMILY()		\
+    do {						\
 	/* Tru64 UNIX V4/V5 provide several ISO C94	\
 	   features protected by the corresponding	\
 	   __STDC_VERSION__ macro.  libstdc++ v3	\

Why are you adding the #undef's?  Do you really need them?

Index: gcc/doc/tm.texi
===================================================================
--- gcc/doc/tm.texi	(revision 165065)
+++ gcc/doc/tm.texi	(working copy)

Please avoid including generated files in the mail.

Index: gcc/doc/tm.texi.in
===================================================================
--- gcc/doc/tm.texi.in	(revision 165065)
+++ gcc/doc/tm.texi.in	(working copy)
@@ -672,7 +672,10 @@ the functions @code{builtin_define}, @co
 @code{builtin_assert}.  When the front end
 calls this macro it provides a trailing semicolon, and since it has
 finished command line option processing your code can use those
-results freely.
+results freely. This macro, however, will be used by all front-end using

                ^ two spaces                                       ^s

Otherwise, the osf5.h, iris6.h and sol2.h changes are ok.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University