From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16339 invoked by alias); 8 Oct 2010 19:34:53 -0000 Received: (qmail 16205 invoked by uid 22791); 8 Oct 2010 19:34:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Oct 2010 19:34:45 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 89C4B185; Fri, 8 Oct 2010 21:34:42 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aotab0i-QuvB; Fri, 8 Oct 2010 21:34:40 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6D438184; Fri, 8 Oct 2010 21:34:40 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id o98JYSO4022137; Fri, 8 Oct 2010 21:34:28 +0200 (MEST) From: Rainer Orth To: FX Cc: gcc-patches@gcc.gnu.org, gfortran List Subject: Re: [patch] Separate {OS,CPU}_CPP_BUILTINS macros into C-family and language-independent macros References: <4D88077B-3233-4D15-94E6-13BE58D29AD5@gmail.com> Date: Fri, 08 Oct 2010 20:29:00 -0000 In-Reply-To: <4D88077B-3233-4D15-94E6-13BE58D29AD5@gmail.com> (FX's message of "Thu, 7 Oct 2010 12:49:34 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg00739.txt.bz2 FX writes: Please don't use application/octet-stream for patch attachments, this makes it considerably harder to cite them. 2010-10-07 Francois-Xavier Coudert PR fortran/42954 * cppbuiltin.c (define_target_specific_builtins, define_builtin_macro_std): New functions. (define_language_independent_builtin_macros): Call define_target_specific_builtins Missing full stop? (define_builtin_macros_for_type_sizes): Something is weird here: what changed? Index: gcc/config/alpha/osf5.h =================================================================== --- gcc/config/alpha/osf5.h (revision 165065) +++ gcc/config/alpha/osf5.h (working copy) @@ -47,6 +47,7 @@ along with GCC; see the file COPYING3. /* Names to predefine in the preprocessor for this target machine. */ +#undef TARGET_OS_CPP_BUILTINS #define TARGET_OS_CPP_BUILTINS() \ do { \ builtin_define_std ("unix"); \ @@ -63,7 +64,11 @@ along with GCC; see the file COPYING3. to be defined for . */ \ if (LONG_DOUBLE_TYPE_SIZE == 128) \ builtin_define ("__X_FLOAT"); \ - \ + } while (0) + +#undef TARGET_OS_CPP_BUILTINS_CFAMILY +#define TARGET_OS_CPP_BUILTINS_CFAMILY() \ + do { \ /* Tru64 UNIX V4/V5 provide several ISO C94 \ features protected by the corresponding \ __STDC_VERSION__ macro. libstdc++ v3 \ Why are you adding the #undef's? Do you really need them? Index: gcc/doc/tm.texi =================================================================== --- gcc/doc/tm.texi (revision 165065) +++ gcc/doc/tm.texi (working copy) Please avoid including generated files in the mail. Index: gcc/doc/tm.texi.in =================================================================== --- gcc/doc/tm.texi.in (revision 165065) +++ gcc/doc/tm.texi.in (working copy) @@ -672,7 +672,10 @@ the functions @code{builtin_define}, @co @code{builtin_assert}. When the front end calls this macro it provides a trailing semicolon, and since it has finished command line option processing your code can use those -results freely. +results freely. This macro, however, will be used by all front-end using ^ two spaces ^s Otherwise, the osf5.h, iris6.h and sol2.h changes are ok. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University