From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 6AC0A383D816 for ; Wed, 11 May 2022 11:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AC0A383D816 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=CeBiTec.Uni-Bielefeld.DE Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 324D7C5603; Wed, 11 May 2022 13:31:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4SAIMFT7iPAe; Wed, 11 May 2022 13:31:27 +0200 (CEST) Received: from itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (itzacchiuatl.CeBiTec.Uni-Bielefeld.DE [129.70.161.157]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id AEB44C523B; Wed, 11 May 2022 13:31:27 +0200 (CEST) Received: (from ro@localhost) by itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id 24BBVRv8009462; Wed, 11 May 2022 13:31:27 +0200 (CEST) X-Authentication-Warning: itzacchiuatl.CeBiTec.Uni-Bielefeld.DE: ro set sender to ro@CeBiTec.Uni-Bielefeld.DE using -f From: Rainer Orth To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: Joseph Myers , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] configure: add --disable-fix-includes References: <2e2c7061-3f3f-fde4-6e8c-d2118820a5b6@suse.cz> Date: Wed, 11 May 2022 13:31:27 +0200 In-Reply-To: ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Wed, 11 May 2022 13:15:26 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3942.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 11:31:30 -0000 Hi Martin, >>> Subject: [PATCH] configure: add --disable-fix-includes >> >> As I've mentioned before, I believe, the command is called fixincludes >> in current gcc docs, and the option should reflect that, not introduce a >> name used nowhere else. > > No, I can't use it, because even with current master using --disable-fixincludes > means the tool is not built at all. It results with: > > g++ -g -DIN_GCC -fPIC -fno-exceptions -fno-rtti > -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings > -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic > -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common > -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ -static-libgcc -o > build/genchecksum \ > build/genchecksum.o ../build-x86_64-pc-linux-gnu/libiberty/pic/libiberty.a > make: *** No rule to make target > '../build-x86_64-pc-linux-gnu/fixincludes/fixinc.sh', needed by > 'stmp-fixinc'. Stop. > make: *** Waiting for unfinished jobs.... and why not just fix that, rather than introducing yet another option? This error suggests current --disable-fixincludes is useless on it's own. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University