From: Doug Evans <dje@google.com>
To: dnovillo@google.com, gcc-patches@gcc.gnu.org
Subject: [RFA 3/8] validate_failures.py: pass options.results for clean build case
Date: Sat, 24 Nov 2012 22:47:00 -0000 [thread overview]
Message-ID: <yjt21ufi7h5d.fsf@ruffy2.mtv.corp.google.com> (raw)
Hi.
This third patch passes options.results to GetSumFiles when fetching the results
for the clean build.
It is useful in my use cases, but I'm not sure it's useful for upstream.
[An alternative is to add another option to specify the results file(s) for the clean
build, but I'm being conservative and not adding an option if I don't have to.]
Ok to check in?
2012-11-24 Doug Evans <dje@google.com>
* testsuite-management/validate_failures.py (CompareBuilds): Pass options.results
to GetSumFiles for clean build.
--- validate_failures.py= 2012-11-19 11:47:29.997632548 -0800
+++ validate_failures.py 2012-11-24 13:26:07.727726123 -0800
@@ -373,7 +373,7 @@ def CompareBuilds(options):
sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)
- clean_sum_files = GetSumFiles(None, options.clean_build)
+ clean_sum_files = GetSumFiles(options.results, options.clean_build)
clean = GetResults(clean_sum_files)
return PerformComparison(clean, actual, options.ignore_missing_failures)
next reply other threads:[~2012-11-24 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-24 22:47 Doug Evans [this message]
2012-11-25 15:40 ` Diego Novillo
2012-11-28 18:55 ` Doug Evans
2012-11-28 20:35 ` Diego Novillo
2012-11-28 23:02 ` Doug Evans
2012-11-28 23:35 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yjt21ufi7h5d.fsf@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).