* [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData
@ 2012-11-24 22:54 Doug Evans
2012-11-26 14:42 ` Diego Novillo
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2012-11-24 22:54 UTC (permalink / raw)
To: dnovillo, gcc-patches
Hi.
This sixth patch simplifies calls to GetBuildData.
It never returns false and always terminates the process with an error message
(which is fine by me).
Ok to check in?
2012-11-24 Doug Evans <dje@google.com>
* testsuite-management/validate_failures.py: Remove pass/fail indicator from
result of GetBuildData.
--- validate_failures.py.options 2012-11-24 13:40:57.616245431 -0800
+++ validate_failures.py 2012-11-24 13:44:05.118039626 -0800
@@ -284,7 +284,7 @@ def GetBuildData():
options.build_dir)
print 'Source directory: %s' % srcdir
print 'Build target: %s' % target
- return srcdir, target, True
+ return srcdir, target
def PrintSummary(msg, summary):
@@ -326,9 +326,7 @@ def PerformComparison(expected, actual,
def CheckExpectedResults():
if not options.manifest:
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
+ (srcdir, target) = GetBuildData()
manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
else:
manifest_path = options.manifest
@@ -348,10 +346,7 @@ def CheckExpectedResults():
def ProduceManifest():
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
-
+ (srcdir, target) = GetBuildData()
manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
if os.path.exists(manifest_path) and not options.force:
Error('Manifest file %s already exists.\nUse --force to overwrite.' %
@@ -369,9 +364,7 @@ def ProduceManifest():
def CompareBuilds():
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
+ (srcdir, target) = GetBuildData()
sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData
2012-11-24 22:54 [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData Doug Evans
@ 2012-11-26 14:42 ` Diego Novillo
0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2012-11-26 14:42 UTC (permalink / raw)
To: Doug Evans; +Cc: gcc-patches
On Sat, Nov 24, 2012 at 5:54 PM, Doug Evans <dje@google.com> wrote:
> 2012-11-24 Doug Evans <dje@google.com>
>
> * testsuite-management/validate_failures.py: Remove pass/fail
> indicator from
> result of GetBuildData.
OK.
Diego.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-26 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-24 22:54 [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData Doug Evans
2012-11-26 14:42 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).