From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18923 invoked by alias); 7 Dec 2018 15:31:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18761 invoked by uid 89); 7 Dec 2018 15:31:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Dec 2018 15:31:04 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gVI5k-00064W-Oj from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Fri, 07 Dec 2018 07:31:00 -0800 Received: from hertz.schwinge.homeip.net (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 7 Dec 2018 15:30:57 +0000 From: Thomas Schwinge To: Chung-Lin Tang CC: Subject: Re: [PATCH 5/6, OpenACC, libgomp] Async re-work, C/C++ testsuite changes In-Reply-To: <8086c63b-f729-891b-3d21-76871d360734@mentor.com> References: <8086c63b-f729-891b-3d21-76871d360734@mentor.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 07 Dec 2018 15:31:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-12/txt/msg00469.txt.bz2 Hi Chung-Lin! On Tue, 25 Sep 2018 21:11:42 +0800, Chung-Lin Tang wrote: > These are the testsuite/libgomp.oacc-c-c++-common/* changes. Please commit the following three hunks to trunk: the code as present doesn't declare its async/wait dependencies correctly. To record the review effort, please include "Reviewed-by: Thomas Schwinge " in the commit log, see . > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c b/l= ibgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > index 2ddfa7d..f553d3d 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > @@ -153,7 +153,7 @@ main (int argc, char **argv) > d[ii] =3D ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; >=20=20 > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N], N)= \ > - async (4) > + wait (1, 2, 3) async (4) > for (int ii =3D 0; ii < N; ii++) > e[ii] =3D a[ii] + b[ii] + c[ii] + d[ii]; >=20=20 > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c b/libgo= mp/testsuite/libgomp.oacc-c-c++-common/data-2.c > index 0c6abe6..81d623a 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > @@ -162,7 +162,7 @@ main (int argc, char **argv) > d[ii] =3D ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; >=20=20 > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ > - wait (1) async (4) > + wait (1, 2, 3) async (4) > for (int ii =3D 0; ii < N; ii++) > e[ii] =3D a[ii] + b[ii] + c[ii] + d[ii]; >=20=20 > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c b/libgo= mp/testsuite/libgomp.oacc-c-c++-common/data-3.c > index 0bf706a..5ec50b8 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > @@ -138,7 +138,7 @@ main (int argc, char **argv) > d[ii] =3D ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; >=20=20 > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ > - wait (1,5) async (4) > + wait (1, 2, 3, 5) async (4) > for (int ii =3D 0; ii < N; ii++) > e[ii] =3D a[ii] + b[ii] + c[ii] + d[ii]; >=20=20 Gr=C3=BC=C3=9Fe Thomas