From: Thomas Schwinge <thomas@codesourcery.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts
Date: Fri, 07 Dec 2018 11:33:00 -0000 [thread overview]
Message-ID: <yxfpk1kl8tcx.fsf@hertz.schwinge.homeip.net> (raw)
In-Reply-To: <12319572-dd02-c946-f2b9-9d047be9c707@mentor.com>
Hi Chung-Lin!
On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> These are the OpenACC specific changes, mostly the re-implementation of async-related acc_* runtime
> library API functions to use the new backend plugin interfaces, in a non-target specific way.
(The patch was missing the "libgomp/oacc-int.h" changes, but I had no
problem replicating these from openacc-gcc-8-branch.)
Does the following make sense?
commit f86b403dbe6ed17afa8d157ec4089ff169a63680
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri Dec 7 12:19:56 2018 +0100
Don't create an asyncqueue just to then test/synchronize with it
---
libgomp/oacc-async.c | 12 ++++++++----
libgomp/oacc-parallel.c | 4 +++-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git libgomp/oacc-async.c libgomp/oacc-async.c
index 553082fe3d4a..c9b134ac3380 100644
--- libgomp/oacc-async.c
+++ libgomp/oacc-async.c
@@ -119,8 +119,11 @@ acc_async_test (int async)
if (!thr || !thr->dev)
gomp_fatal ("no device active");
- goacc_aq aq = lookup_goacc_asyncqueue (thr, true, async);
- return thr->dev->openacc.async.test_func (aq);
+ goacc_aq aq = lookup_goacc_asyncqueue (thr, false, async);
+ if (!aq)
+ return 1;
+ else
+ return thr->dev->openacc.async.test_func (aq);
}
int
@@ -148,8 +151,9 @@ acc_wait (int async)
struct goacc_thread *thr = get_goacc_thread ();
- goacc_aq aq = lookup_goacc_asyncqueue (thr, true, async);
- thr->dev->openacc.async.synchronize_func (aq);
+ goacc_aq aq = lookup_goacc_asyncqueue (thr, false, async);
+ if (aq)
+ thr->dev->openacc.async.synchronize_func (aq);
}
/* acc_async_wait is an OpenACC 1.0 compatibility name for acc_wait. */
diff --git libgomp/oacc-parallel.c libgomp/oacc-parallel.c
index 7b6a6e515018..0be48f98036f 100644
--- libgomp/oacc-parallel.c
+++ libgomp/oacc-parallel.c
@@ -491,7 +491,9 @@ goacc_wait (int async, int num_waits, va_list *ap)
{
int qid = va_arg (*ap, int);
- goacc_aq aq = get_goacc_asyncqueue (qid);
+ goacc_aq aq = lookup_goacc_asyncqueue (thr, false, qid);
+ if (!aq)
+ continue;
if (acc_dev->openacc.async.test_func (aq))
continue;
if (async == acc_async_sync)
Grüße
Thomas
next prev parent reply other threads:[~2018-12-07 11:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 13:11 Chung-Lin Tang
2018-12-07 11:33 ` Thomas Schwinge [this message]
2018-12-07 14:19 ` Chung-Lin Tang
2018-12-14 14:11 ` Thomas Schwinge
2018-12-14 14:17 ` Thomas Schwinge
2018-12-14 14:52 ` Chung-Lin Tang
2018-12-17 13:52 ` Thomas Schwinge
2018-12-18 9:35 ` Chung-Lin Tang
2018-12-14 14:32 ` Thomas Schwinge
2018-12-14 14:42 ` Chung-Lin Tang
2018-12-17 13:56 ` Thomas Schwinge
2018-12-14 14:54 ` Thomas Schwinge
2018-12-14 15:01 ` Chung-Lin Tang
2018-12-17 14:11 ` Thomas Schwinge
2018-12-14 14:56 ` Thomas Schwinge
2018-12-17 11:03 ` Chung-Lin Tang
2018-12-17 14:32 ` Thomas Schwinge
2018-12-18 10:03 ` Chung-Lin Tang
2018-12-18 11:44 ` Thomas Schwinge
2018-12-18 15:06 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Chung-Lin Tang
2018-12-18 21:04 ` Thomas Schwinge
2018-12-21 16:25 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v3) Chung-Lin Tang
2018-12-28 14:52 ` Thomas Schwinge
2019-01-02 12:46 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Chung-Lin Tang
2019-01-05 9:47 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v4) Chung-Lin Tang
2019-01-07 14:16 ` Thomas Schwinge
2019-01-08 14:04 ` Chung-Lin Tang
2019-01-07 14:15 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxfpk1kl8tcx.fsf@hertz.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).