From: Thomas Schwinge <thomas@codesourcery.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts
Date: Fri, 14 Dec 2018 14:32:00 -0000 [thread overview]
Message-ID: <yxfplg4suqke.fsf@hertz.schwinge.homeip.net> (raw)
In-Reply-To: <12319572-dd02-c946-f2b9-9d047be9c707@mentor.com>
Hi Chung-Lin!
On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> void
> acc_wait_async (int async1, int async2)
> {
> + struct goacc_thread *thr = get_goacc_thread ();
>
> + goacc_aq aq2 = lookup_goacc_asyncqueue (thr, true, async2);
> + goacc_aq aq1 = lookup_goacc_asyncqueue (thr, false, async1);
> + if (!aq1)
> + gomp_fatal ("invalid async 1");
> + if (aq1 == aq2)
> + gomp_fatal ("identical parameters");
>
> + thr->dev->openacc.async.synchronize_func (aq1);
> + thr->dev->openacc.async.serialize_func (aq1, aq2);
> }
Invoked as "acc_wait_async ([...], acc_async_sync)" (as used in a test
case that I'll soon submit/commit), we'll end up with "aq2 == NULL", and
will segfault in the nvptx "openacc.async.serialize_func".
Good to fix as follows?
commit 448ff855bd954a72b5edb19fc1f3d481833fcb59
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Thu Dec 13 17:43:42 2018 +0100
into async re-work: adjust for test case added in "[PR88484] OpenACC wait directive without wait argument but with async clause"
---
libgomp/oacc-async.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git libgomp/oacc-async.c libgomp/oacc-async.c
index 7e61b5dc0a05..a38e42781aa0 100644
--- libgomp/oacc-async.c
+++ libgomp/oacc-async.c
@@ -196,7 +196,8 @@ acc_wait_async (int async1, int async2)
gomp_fatal ("identical parameters");
thr->dev->openacc.async.synchronize_func (aq1);
- thr->dev->openacc.async.serialize_func (aq1, aq2);
+ if (aq2)
+ thr->dev->openacc.async.serialize_func (aq1, aq2);
}
void
Grüße
Thomas
next prev parent reply other threads:[~2018-12-14 14:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 13:11 Chung-Lin Tang
2018-12-07 11:33 ` Thomas Schwinge
2018-12-07 14:19 ` Chung-Lin Tang
2018-12-14 14:11 ` Thomas Schwinge
2018-12-14 14:17 ` Thomas Schwinge
2018-12-14 14:52 ` Chung-Lin Tang
2018-12-17 13:52 ` Thomas Schwinge
2018-12-18 9:35 ` Chung-Lin Tang
2018-12-14 14:32 ` Thomas Schwinge [this message]
2018-12-14 14:42 ` Chung-Lin Tang
2018-12-17 13:56 ` Thomas Schwinge
2018-12-14 14:54 ` Thomas Schwinge
2018-12-14 15:01 ` Chung-Lin Tang
2018-12-17 14:11 ` Thomas Schwinge
2018-12-14 14:56 ` Thomas Schwinge
2018-12-17 11:03 ` Chung-Lin Tang
2018-12-17 14:32 ` Thomas Schwinge
2018-12-18 10:03 ` Chung-Lin Tang
2018-12-18 11:44 ` Thomas Schwinge
2018-12-18 15:06 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Chung-Lin Tang
2018-12-18 21:04 ` Thomas Schwinge
2018-12-21 16:25 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v3) Chung-Lin Tang
2018-12-28 14:52 ` Thomas Schwinge
2019-01-02 12:46 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Chung-Lin Tang
2019-01-05 9:47 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v4) Chung-Lin Tang
2019-01-07 14:16 ` Thomas Schwinge
2019-01-08 14:04 ` Chung-Lin Tang
2019-01-07 14:15 ` [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v2) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxfplg4suqke.fsf@hertz.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).