From mboxrd@z Thu Jan 1 00:00:00 1970 From: tromey@cygnus.com To: java-gnats@sourceware.cygnus.com Subject: libgcj/1152: _REENTRANT should be defined more consistently Date: Wed, 20 Dec 2000 12:19:00 -0000 Message-id: <19990801002438.4116.qmail@egcs.cygnus.com> X-SW-Source: 2000-q4/msg00944.html List-Id: >Number: 1152 >Category: libgcj >Synopsis: _REENTRANT should be defined more consistently >Confidential: no >Severity: serious >Priority: medium >Responsible: tromey >State: closed >Class: sw-bug >Submitter-Id: net >Arrival-Date: Wed Dec 20 12:16:05 PST 2000 >Closed-Date: Fri Apr 21 13:23:05 PDT 2000 >Last-Modified: Fri Apr 21 13:50:00 PDT 2000 >Originator: Tom Tromey >Release: 2.95 >Organization: >Environment: Any system using POSIX threads >Description: Currently we define _REENTRANT in inconsistent ways, sometimes not at all. On some platforms we rely on the Boehm GC to define it for us. This is wrong. Instead we should always define _REENTRANT when we are using POSIX threads. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: Formerly PR libgcj/15 State-Changed-From-To: open->closed State-Changed-By: tromey State-Changed-When: Fri Apr 21 13:23:05 2000 State-Changed-Why: I'm checking in a fix for this. From: tromey@cygnus.com To: java-gnats@sourceware.cygnus.com, tromey@cygnus.com Cc: Subject: Re: libgcj/15 Date: 21 Apr 2000 20:23:05 -0000 Synopsis: _REENTRANT should be defined more consistently State-Changed-From-To: open->closed State-Changed-By: tromey State-Changed-When: Fri Apr 21 13:23:05 2000 State-Changed-Why: I'm checking in a fix for this. http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=15&database=java From: tromey@sourceware.cygnus.com To: java-gnats@sourceware.cygnus.com Cc: Subject: libgcj/15 Date: 21 Apr 2000 20:38:43 -0000 CVSROOT: /cvs/java Module name: libgcj Changes by: tromey@sourceware.cygnus.com 00/04/21 13:38:43 Modified files: libjava : ChangeLog libjava/java/io: natFile.cc libjava/java/lang: natSystem.cc libjava/java/net: natInetAddress.cc libjava/java/util: natGregorianCalendar.cc Log message: Fix for PR libgcj/15: * java/util/natGregorianCalendar.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * java/net/natInetAddress.cc (_REENTRANT): Don't define. * java/lang/natSystem.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * java/io/natFile.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * configure: Rebuilt. * configure.in: If using POSIX threads, define _REENTRANT if needed. Define _POSIX_PTHREAD_SEMANTICS. Don't define GETHOSTBYNAME_R_NEEDS_REENTRANT. Patches: http://gcc.gnu.org/cgi-bin/gcc/libjava/ChangeLog.diff?cvsroot=java&r1=1.354&r2=1.355 http://gcc.gnu.org/cgi-bin/gcc/libjava/java/io/natFile.cc.diff?cvsroot=java&r1=1.6&r2=1.7 http://gcc.gnu.org/cgi-bin/gcc/libjava/java/lang/natSystem.cc.diff?cvsroot=java&r1=1.20&r2=1.21 http://gcc.gnu.org/cgi-bin/gcc/libjava/java/net/natInetAddress.cc.diff?cvsroot=java&r1=1.13&r2=1.14 http://gcc.gnu.org/cgi-bin/gcc/libjava/java/util/natGregorianCalendar.cc.diff?cvsroot=java&r1=1.5&r2=1.6 From: tromey@sourceware.cygnus.com To: java-gnats@sourceware.cygnus.com Cc: Subject: libgcj/15 Date: 21 Apr 2000 20:46:11 -0000 CVSROOT: /cvs/java Module name: libgcj Changes by: tromey@sourceware.cygnus.com 00/04/21 13:46:11 Modified files: libjava : Makefile.in configure configure.in Log message: Fix for PR libgcj/15: * java/util/natGregorianCalendar.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * java/net/natInetAddress.cc (_REENTRANT): Don't define. * java/lang/natSystem.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * java/io/natFile.cc (_REENTRANT, _POSIX_PTHREAD_SEMANTICS): Don't define. * configure: Rebuilt. * configure.in: If using POSIX threads, define _REENTRANT if needed. Define _POSIX_PTHREAD_SEMANTICS. Don't define GETHOSTBYNAME_R_NEEDS_REENTRANT. Patches: http://gcc.gnu.org/cgi-bin/gcc/libjava/Makefile.in.diff?cvsroot=java&r1=1.64&r2=1.65 http://gcc.gnu.org/cgi-bin/gcc/libjava/configure.diff?cvsroot=java&r1=1.57&r2=1.58 http://gcc.gnu.org/cgi-bin/gcc/libjava/configure.in.diff?cvsroot=java&r1=1.56&r2=1.57 >Unformatted: