libgcj/1281: Macro-inconsistency

libgcj/1281: Macro-inconsistency

[Thomas.Arend]

>Number:         1281
>Category:       libgcj
>Synopsis:       Macro-inconsistency
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tromey
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 20 12:18:37 PST 2000
>Closed-Date:    
>Last-Modified:  Fri Jun 16 09:00:00 PDT 2000
>Originator:     Thomas Arend
>Release:        libgcj-snapshot-2000-06-15
>Organization:
>Environment:
SUN/Solaris
>Description:
The macro MAKE_THROW_FRAME is inconsistently defined;
it takes one parameter in libjava/include/{i386,ppc}-signal.h
and no parameter in libjava/include/{sparc,win32}-signal.h.
This breaks compilation of libjava/prims.cc on SUN/Solaris.
>How-To-Repeat:

>Fix:
Fix definition of MAKE_THROW_FRAME in libjava/include/{sparc,win32}-signal.h
>Release-Note:

>Audit-Trail:

Formerly PR libgcj/261

State-Changed-From-To: open->feedback
State-Changed-By: tromey
State-Changed-When: Fri Jun 16 08:50:57 2000
State-Changed-Why:
    I've checked in a fix for this.
    Andrew did do this initially, but somehow that patch
    didn't make it into sourceware (my fault).
    I've fixed it.
    Can you try it out?  Either way, get back to me -- if
    you can't try it I will just close the PR

From: tromey@cygnus.com
To: Thomas.Arend@infoscore.de, java-gnats@sourceware.cygnus.com,
  tromey@cygnus.com
Cc:  
Subject: Re: libgcj/261
Date: 16 Jun 2000 15:50:57 -0000

 Synopsis: Macro-inconsistency
 
 State-Changed-From-To: open->feedback
 State-Changed-By: tromey
 State-Changed-When: Fri Jun 16 08:50:57 2000
 State-Changed-Why:
     I've checked in a fix for this.
     Andrew did do this initially, but somehow that patch
     didn't make it into sourceware (my fault).
     I've fixed it.
     Can you try it out?  Either way, get back to me -- if
     you can't try it I will just close the PR
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=261&database=java

From: tromey@sourceware.cygnus.com
To: java-gnats@sourceware.cygnus.com
Cc:  
Subject: libgcj/261
Date: 16 Jun 2000 15:52:25 -0000

 CVSROOT:	/cvs/java
 Module name:	libgcj
 Changes by:	tromey@sourceware.cygnus.com	00/06/16 08:52:24
 
 Modified files:
 	libjava        : ChangeLog 
 	libjava/include: sparc-signal.h win32-signal.h 
 
 Log message:
 	Fix for PR libgcj/261:
 	* include/win32-signal.h (MAKE_THROW_FRAME): Added `_exception'
 	argument.
 	* include/sparc-signal.h (MAKE_THROW_FRAME): Added `_exception'
 	argument.  (This is a patch from long ago that somehow went
 	missing.)
 
 Patches:
 http://gcc.gnu.org/cgi-bin/gcc/libjava/ChangeLog.diff?cvsroot=java&r1=1.392&r2=1.393
 http://gcc.gnu.org/cgi-bin/gcc/libjava/include/sparc-signal.h.diff?cvsroot=java&r1=1.6&r2=1.7
 http://gcc.gnu.org/cgi-bin/gcc/libjava/include/win32-signal.h.diff?cvsroot=java&r1=1.1&r2=1.2
 
>Unformatted: