From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryce McKinlay To: bryce@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org Subject: Re: libgcj/1736 Date: Mon, 26 Mar 2001 18:26:00 -0000 Message-id: <20010327022601.23244.qmail@sourceware.cygnus.com> X-SW-Source: 2001-03/msg00284.html List-Id: The following reply was made to PR libgcj/1736; it has been noted by GNATS. From: Bryce McKinlay To: "Billinghurst, David (CRTS)" Cc: "'gcc-gnats@gcc.gnu.org'" Subject: Re: libgcj/1736 Date: Tue, 27 Mar 2001 14:32:38 +1200 This is a multi-part message in MIME format. --------------66D64A85B340CEDFCCA8D529 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Here's a modified patch that seems to work for me. Its also a bit cleaner/simpler IMO, assuming it works for irix as well. Can you try it out? regards [ bryce ] --------------66D64A85B340CEDFCCA8D529 Content-Type: text/plain; charset=us-ascii; name="libgcj-objectlist-2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="libgcj-objectlist-2.patch" 2001-03-27 Bryce McKinlay David Billinghurst * Makefile.am (libffi_files): Use $(shell) wrapper instead of back quotes. (libgcj.la): Echo the list of object files one at a time, using a for loop. (libgcjx.la): Likewise. * Makefile.in: Rebuilt. Index: Makefile.am =================================================================== RCS file: /cvs/gcc/gcc/libjava/Makefile.am,v retrieving revision 1.129.2.5 diff -u -r1.129.2.5 Makefile.am --- Makefile.am 2001/03/27 00:17:01 1.129.2.5 +++ Makefile.am 2001/03/27 02:15:01 @@ -132,7 +132,7 @@ x_javao_files = $(x_java_source_files:.java=.lo) ## Extract the libffi object file names. -libffi_files = `find ../libffi/ \-name '*.lo'` +libffi_files = $(shell find ../libffi/ \-name '*.lo') libgcj_la_SOURCES = prims.cc posix.cc jni.cc exception.cc \ resolve.cc defineclass.cc interpret.cc name-finder.cc \ @@ -265,13 +265,19 @@ ## Pass the list of object files to libtool in a temporary file to ## avoid tripping platform command line length limits. libgcj.la: $(libgcj_la_OBJECTS) $(libgcj_la_DEPENDENCIES) - @echo $(libgcj_la_OBJECTS) > libgcj.objectlist; - @echo $(libgcj_la_LIBADD) >> libgcj.objectlist; + @echo "Creating list of libgcj object files..."; + @rm -f libgcj.objectlist; + @for f in $(libgcj_la_OBJECTS) $(libgcj_la_LIBADD); do \ + echo $$f >> libgcj.objectlist; \ + done $(libgcj_la_LINK) -objectlist libgcj.objectlist -rpath $(toolexeclibdir) $(libgcj_la_LDFLAGS) $(LIBS) libgcjx.la: $(libgcjx_la_OBJECTS) $(libgcjx_la_DEPENDENCIES) - @echo $(libgcjx_la_OBJECTS) > libgcjx.objectlist; - @echo $(libgcjx_la_LIBADD) >> libgcjx.objectlist; + @echo "Creating list of libgcjx object files..."; + @rm -f libgcjx.objectlist; + @for f in $(libgcjx_la_OBJECTS) $(libgcjx_la_LIBADD); do \ + echo $$f >> libgcjx.objectlist; \ + done $(libgcjx_la_LINK) -objectlist libgcjx.objectlist -rpath $(toolexeclibdir) $(libgcjx_la_LDFLAGS) $(LIBS) --------------66D64A85B340CEDFCCA8D529--