Re: libgcj/2429: java.text.MessageFormat broken

Re: libgcj/2429: java.text.MessageFormat broken

[Tom Tromey]

The following reply was made to PR libgcj/2429; it has been noted by GNATS.

From: Tom Tromey <tromey@redhat.com>
To: torsten.rueger@firsthop.com
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libgcj/2429: java.text.MessageFormat broken
Date: 30 Mar 2001 21:22:59 -0700

 >>>>> "Torsten" == torsten rueger <torsten.rueger@firsthop.com> writes:
 
 Torsten> At first I could not instantiate MessageFormat with "{1,time}
 Torsten> {2}:{3} {4}". I fixed this with an else in line 91 in
 Torsten> java.text.MessageFormat. Then using it caused illegal
 Torsten> Argument. Attatched is a small Test program that should show
 Torsten> the problem.
 
 I agree that the `else' fix is required.  Thanks.
 
 The other bug is in your program.
 
 You can make your program work by changing main to use:
 
     LogFile log = new LogFile("log.file","{0,time} {1}:{2} {3}","ERROR",
 			      null,true);
     log.flush();
 
 Our MessageFormat doesn't give very nice error messages,
 unfortunately.  I will change this PR to reflect this as the real bug
 -- much debugging would have been saved if it did.
 
 Tom

libgcj/2429: java.text.MessageFormat broken

[torsten.rueger]

>Number:         2429
>Category:       libgcj
>Synopsis:       java.text.MessageFormat broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 29 23:26:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     torsten.rueger@firsthop.com
>Release:        gcc version 3.0 20010320 (prerelease)
>Organization:
>Environment:
Linux inception 2.2.12-20 #1 Mon Sep 27 10:40:35 EDT 1999 i686 unknown
Configured with: ../gcc-20010320/configure --enable-threads=posix --prefix=/tmp/local/ --enable-shared --enable-languages=c++,java
>Description:
At first I could not instantiate MessageFormat with "{1,time} {2}:{3} {4}". I fixed this with an else in line 91 in java.text.MessageFormat. Then using it caused illegal Argument. Attatched is a small Test program that should show the problem.
>How-To-Repeat:
Compile and run attatched file
>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: application/octet-stream; name="LogFile.java"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="LogFile.java"

aW1wb3J0IGphdmEuaW8uQnVmZmVyZWRPdXRwdXRTdHJlYW07CmltcG9ydCBqYXZhLmlvLklPRXhj
ZXB0aW9uOwppbXBvcnQgamF2YS5pby5GaWxlT3V0cHV0U3RyZWFtOwppbXBvcnQgamF2YS5pby5J
T0V4Y2VwdGlvbjsKaW1wb3J0IGphdmEuaW8uUHJpbnRTdHJlYW07CmltcG9ydCBqYXZhLnV0aWwu
RGF0ZTsKaW1wb3J0IGphdmEudXRpbC5Qcm9wZXJ0aWVzOwppbXBvcnQgamF2YS50ZXh0Lk1lc3Nh
Z2VGb3JtYXQ7CgpwdWJsaWMgY2xhc3MgTG9nRmlsZSAgewoKICBwdWJsaWMgc3RhdGljIHZvaWQg
bWFpbihTdHJpbmcgW10gYXJncykgdGhyb3dzIElPRXhjZXB0aW9uIHsKICAgIExvZ0ZpbGUgbG9n
ID0gbmV3IExvZ0ZpbGUoImxvZy5maWxlIiwiezEsdGltZX0gezJ9OnszfSB7NH0iLCJFUlJPUiIs
CgkJCSAgICAgIG51bGwsdHJ1ZSk7CiAgICBsb2cubG9nKCJIRUxMTyIsIkVSUk9SIiwgIldoYXQg
aXMgd3JvbmciICxudWxsKTsKICB9CgogICBQcm9wZXJ0aWVzIF9sZXZlbHM7CiAgIGJvb2xlYW4g
X3RyYWNlOwogICBQcmludFN0cmVhbSBfb3V0OwogICBNZXNzYWdlRm9ybWF0IF9tZjsgCiAgIFN0
cmluZyBfZGVmYXVsdExldmVsOwogICBTdHJpbmcgX25hbWU7CgogICAvKioKICAgICAqIENyZWF0
ZSBhIG5ldyBMb2dGaWxlIGluc3RhbmNlLiBUaGUgTG9nRmlsZSBjYW4gYmUgY29uZmlndXJlZCAK
ICAgICAqIHRvIGFjY2VwdCBkaWZmZXJlbnQga2luZHMgb2YgbG9nIG1lc3NhZ2VzLCBhbmQgdG8g
cHJpbnQgdGhlbQogICAgICogb3V0IGluIGRpZmZlcmVudCB3YXlzLiAKICAgICAqIDxwPgogICAg
ICogVGhlIGxldmVscyBQcm9wZXJ0aWVzIG1hcHMgYSBsb2cgbmFtZSB0byBhIGxvZyBsZXZlbCBz
dHJpbmcKICAgICAqIGRlc2NyaWJpbmcgd2hhdCBsZXZlbCBvZiBsb2dnaW5nIGlzIGRlc2lyZWQg
Zm9yIHRoYXQgdGFyZ2V0LiAKICAgICAqIFRoZSBsZXZlbHMgY29ycmVzcG9uZCB0byBzZXZlcml0
eSBsZXZlbHM6IEFMTCwgREVCVUcsIElORk8sIAogICAgICogTk9USUNFLCBXQVJOSU5HLCBFUlJP
UiwgYW5kIE5PTkUuCiAgICAgKiA8cD4KICAgICAqIEBwYXJhbSBmaWxlTmFtZSB3aGVyZSB0aGUg
bG9nIHNob3VsZCB3cml0ZQogICAgICogQHBhcmFtIGxldmVscyBhIGhhc2h0YWJsZSBtYXBwaW5n
IGxvZyBuYW1lcyB0byBsZXZlbHMgKG1heSBiZSBudWxsKQogICAgICogQHBhcmFtIHRyYWNlIHRy
dWUgaWYgdGhpcyBsb2cgc2hvdWxkIHRyYWNlIG91dCBleGNlcHRpb25zCiAgICAgKiBAcGFyYW0g
Zmx1c2ggdHJ1ZSBpZiB0aGlzIGxvZyBzaG91bGQgZmx1c2ggYWZ0ZXIgZXZlcnkgbWVzc2FnZQog
ICAgICovCiAgIHB1YmxpYyBMb2dGaWxlKFN0cmluZyBmaWxlLCBTdHJpbmcgZm9ybWF0LCBTdHJp
bmcgZGVmYXVsdExldmVsLCBQcm9wZXJ0aWVzIGxldmVscywgYm9vbGVhbiB0cmFjZSkgCiAgICAg
IHRocm93cyBJT0V4Y2VwdGlvbgogICB7CiAgICAgIHRoaXMoZmlsZSwgbmV3IFByaW50U3RyZWFt
KAogICAgICAgICAgICBuZXcgQnVmZmVyZWRPdXRwdXRTdHJlYW0obmV3IEZpbGVPdXRwdXRTdHJl
YW0oZmlsZSx0cnVlKSkpLCAKICAgICAgICAgICAgZm9ybWF0LCBkZWZhdWx0TGV2ZWwsIGxldmVs
cywgdHJhY2UpOwogICB9CgogICAvKioKICAgICAqIENyZWF0ZSBhIG5ldyBsb2dmaWxlCiAgICAg
KiBAcGFyYW0gbmFtZSB3aGF0IHdlIHdhbnQgdG8gY2FsbCBpdCAoZGVidWdnaW5nIHB1cnBvc2Vz
KQogICAgICogQHBhcmFtIG91dCB3aGVyZSB3ZSB3cml0ZSBvdXIgb3V0cHV0CiAgICAgKiBAcGFy
YW0gZm9ybWF0IE1lc3NhZ2VGb3JtYXQgZm9yIG91ciBvdXRwdXQKICAgICAqIEBwYXJhbSBkZWZh
dWx0TGV2ZWwgV2hhdCBsZXZlbCBkbyB3ZSB1c2UgZm9yIHVua25vd24gc291cmNlcz8KICAgICAq
IEBwYXJhbSBsZXZlbHMgV2hhdCBsZXZlbHMgZG8gd2UgdXNlIGZvciBzcGVjaWZpYyBzb3VyY2Vz
IChtYXkgYmUgbnVsbCkKICAgICAqIEBwYXJhbSB0cmFjZSBEbyB3ZSB3cml0ZSBvdXQgZXhjZXB0
aW9ucyAodHJ1ZSkgb3Igbm90IChmYWxzZSk/CiAgICAgKi8KICAgcHVibGljIExvZ0ZpbGUoU3Ry
aW5nIG5hbWUsIFByaW50U3RyZWFtIG91dCwgU3RyaW5nIGZvcm1hdCwgCiAgICAgICAgICAgICAg
IFN0cmluZyBkZWZhdWx0TGV2ZWwsIFByb3BlcnRpZXMgbGV2ZWxzLCBib29sZWFuIHRyYWNlKQog
ICB7CiAgICAgIF9tZiA9IG5ldyBNZXNzYWdlRm9ybWF0KGZvcm1hdCk7CiAgICAgIF9sZXZlbHMg
PSBsZXZlbHM7CiAgICAgIF90cmFjZSA9IHRyYWNlOwogICAgICBfb3V0ID0gb3V0OwogICAgICBf
ZGVmYXVsdExldmVsID0gZGVmYXVsdExldmVsOwogICAgICBfbmFtZSA9IG5hbWU7CiAgIH0KCiAg
IHB1YmxpYyBTdHJpbmcgdG9TdHJpbmcoKSB7CiAgICAgIHJldHVybiBnZXROYW1lKCk7CiAgIH0K
CiAgIHB1YmxpYyBTdHJpbmcgZ2V0TmFtZSgpIHsKICAgICAgcmV0dXJuICJMb2dGaWxlKCIgKyBf
bmFtZSArICIsICIgKyBfZGVmYXVsdExldmVsICsgIiwgIiArIF9sZXZlbHMgKyAiKSI7CiAgIH0K
CiAgIHByaXZhdGUgT2JqZWN0W10gX2FyZ3MgPSBuZXcgT2JqZWN0WzRdOwogICBwcml2YXRlIGxv
bmcgX3RpbWVzdGFtcCA9IDA7CiAgIHB1YmxpYyB2b2lkIGxvZyhTdHJpbmcgbmFtZSwgU3RyaW5n
IGxldmVsLCBTdHJpbmcgbWVzc2FnZSwgRXhjZXB0aW9uIGUpCiAgIHsKICAgICAgbG9uZyB0aW1l
ID0gU3lzdGVtLmN1cnJlbnRUaW1lTWlsbGlzKCk7CiAgICAgIHN5bmNocm9uaXplZChfYXJncykg
ewogICAgICAgICBpZiAoKHRpbWUgLSBfdGltZXN0YW1wKSA+IDEwMDApIHsKICAgICAgICAgICAg
X2FyZ3NbMF0gPSBuZXcgRGF0ZSgpOwogICAgICAgICB9CiAgICAgICAgIF9hcmdzWzFdID0gbmFt
ZTsKICAgICAgICAgX2FyZ3NbMl0gPSBsZXZlbDsKICAgICAgICAgX2FyZ3NbM10gPSBtZXNzYWdl
OwoJIF9vdXQucHJpbnRsbihfbWYuZm9ybWF0KF9hcmdzKSk7CiAgICAgICAgIC8vX291dC5wcmlu
dGxuKF9hcmdzWzBdICsiICAiICsgbmFtZSArICIgICIgK2xldmVsICsgIiAiKyBtZXNzYWdlKTsK
ICAgICAgICAgaWYgKF90cmFjZSAmJiAoZSAhPSBudWxsKSkgewogICAgICAgICAgICBlLnByaW50
U3RhY2tUcmFjZShfb3V0KTsKICAgICAgICAgfQogICAgICB9CiAgIH0KCiAgIHB1YmxpYyB2b2lk
IGZsdXNoKCkgewogICAgICBfb3V0LmZsdXNoKCk7CiAgIH0KCn0KCgo=