Re: java/2449: PrintStream defines 'out' as BufferedOutputStream

Re: java/2449: PrintStream defines 'out' as BufferedOutputStream

[Tom Tromey]

The following reply was made to PR java/2449; it has been noted by GNATS.

From: Tom Tromey <tromey@redhat.com>
To: joerg_brunsmann@yahoo.de
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: java/2449: PrintStream defines 'out' as BufferedOutputStream
Date: 02 Apr 2001 13:51:54 -0600

 I checked in a Mauve test for this.
 
 Tom

Re: java/2449: PrintStream defines 'out' as BufferedOutputStream

[Tom Tromey]

The following reply was made to PR java/2449; it has been noted by GNATS.

From: Tom Tromey <tromey@redhat.com>
To: joerg_brunsmann@yahoo.de
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: java/2449: PrintStream defines 'out' as BufferedOutputStream
Date: 02 Apr 2001 14:12:45 -0600

 Joerg> Is the suggestion correct to remove the out from PrintStream?  
 
 I looked at this today.  The fix is more complex than simply removing
 the field.  I have a patch which I am testing now.  If there are no
 regressions then I will check it in.
 
 Tom

Re: java/2449: PrintStream defines 'out' as BufferedOutputStream

[Tom Tromey]

The following reply was made to PR java/2449; it has been noted by GNATS.

From: Tom Tromey <tromey@redhat.com>
To: joerg_brunsmann@yahoo.de
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: java/2449: PrintStream defines 'out' as BufferedOutputStream
Date: 01 Apr 2001 18:21:12 -0600

 >>>>> "Joerg" == joerg brunsmann <joerg_brunsmann@yahoo.de> writes:
 
 Joerg> public void setOutputStream(OutputStream s) {
 Joerg>         out = s;
 Joerg> }
  
 I don't see how this can work given that the `out' field is
 package-private.
 
 Oops, that's probably the bug -- this class doesn't need its own `out'
 field.  I'll test this.
 
 Tom

Re: java/2449: PrintStream defines 'out' as BufferedOutputStream

[Bryce McKinlay]

The following reply was made to PR java/2449; it has been noted by GNATS.

From: Bryce McKinlay <bryce@waitaki.otago.ac.nz>
To: joerg_brunsmann@yahoo.de
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: java/2449: PrintStream defines 'out' as BufferedOutputStream
Date: Mon, 02 Apr 2001 12:25:05 +1200

 joerg_brunsmann@yahoo.de wrote:
 
 > LogStream.java: In class `LogStream':
 > LogStream.java: In method `LogStream.setOutputStream(java.io.OutputStream)':
 > LogStream.java:13: Incompatible type for `='. Explicit cast needed to convert `java.io.OutputStream' to `java.io.BufferedOutputStream'.
 >         out = s;
 >                ^
 > 1 error
 >
 > This is a correct error message because the libjava
 > PrintStream class defines 'out' as BufferedOutputStream.
 > Is the suggestion correct to remove the out from PrintStream?
 
 Yes. A patch would be most welcome.
 
 regards
 
   [ bryce ]
 
 

java/2449: PrintStream defines 'out' as BufferedOutputStream

[joerg_brunsmann]

>Number:         2449
>Category:       java
>Synopsis:       PrintStream defines 'out' as BufferedOutputStream
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 01 01:46:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     joerg_brunsmann@yahoo.de
>Release:        unknown-1.0
>Organization:
>Environment:
gcc 3.0
>Description:
While trying to compile the kaffe rmi classes
I found this:
 
The rmi implementation defines a class called
LogStream which extends PrintStream:
 
import java.io.*;
 
public class LogStream
        extends PrintStream {
 
private LogStream(OutputStream s) {
  super(s);
}
 
public void setOutputStream(OutputStream s) {
        out = s;
}
 
}
 
$ gcj LogStream.java
 
gives:
 
LogStream.java: In class `LogStream':
LogStream.java: In method `LogStream.setOutputStream(java.io.OutputStream)':
LogStream.java:13: Incompatible type for `='. Explicit cast needed to convert `java.io.OutputStream' to `java.io.BufferedOutputStream'.
        out = s;
               ^
1 error
 
This is a correct error message because the libjava
PrintStream class defines 'out' as BufferedOutputStream.
Is the suggestion correct to remove the out from PrintStream?  
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: